Skip to content

ci(lint): add RUST-033 lint lane (soldr lint rust --cross-dylint) - #1795

Merged
zackees merged 1 commit into
mainfrom
agent/rust-033-lint-lane
Oct 30, 2026
Merged

zackees merged 1 commit into
mainfrom
agent/rust-033-lint-lane

Conversation

@zackees

@zackees zackees commented Oct 30, 2026

Copy link
Copy Markdown
Member

Adopts fleet policy RUST-033 (forge-ci/ci.yml#511, #512) for FastLED/fbuild — first slice.

What this adds

A local-gate lane named lint that runs the repository's full RUST-032 lint
phase as one command:

soldr lint rust --cross-dylint

That covers rustfmt, Clippy for the host and for every target in
[workspace.metadata.soldr].targets
(all eight), plus Dylint per target via
--cross-dylint using the lint libraries' pinned nightly. Cross targets lint
from the Linux host through soldr's prebuilt rust-std, so no native
Windows/macOS machine is needed. A non-Linux host is a hard error rather than a
silent reduction in coverage.

ci-attestations.yml now declares rust/<target>/{clippy,dylint} for all eight
declared targets on the lint lane, so one successful lane run attests
per-target coverage instead of a single host-only gate. ci.toml lists the new
lane; ci/local_gate.py dispatches --lane lint.

New files: ci/local_lint_gate.py, ci/test_local_lint_gate.py (registered in
ci-workflow-drift.yml and the gate's own unittest list).

Deliberately opt-in for now

--lane lint is not part of the default local-gate run yet. RUST-033 rule 6
makes a mandatory lane conditional on a warm re-run costing at most
max(30 s, 10% of cold). This change has not measured that, and the cold pass over
eight targets plus Dylint is long. Flipping lane == "lint" to
lane in (None, "lint") is a one-line follow-up once the numbers exist. The
lint lane is additive: existing lane behaviour is unchanged.

Not done here (needs upstream or owner action)

  • Enforcement (RUST-033 rules 3/4) — check-push refusing an unattested head
    "whatever the gate's mode", and merge-queue requiring a Dylint attestation,
    are ci-lint behaviours; the pinned ci-lint has no mandatory-lane concept
    and its gate definition only carries lane/fidelity. Needs a ci.yml change,
    then wiring here. The lane and its gates are the prerequisite.
  • Merge-queue ruleset — requiring the lint/Dylint check on main is a
    repository-settings change only the owner can make.
  • Measurement — a cold/warm timing pair for the lint lane.

Static gate state

ci-lint local-gate lint on this branch reports 14 pre-existing violations
(replay dependency coverage for ci-minimal.yml/dylint.yml, missing verify
needs in ci-minimal.yml, and bare cargo/rustup in hw-ci.yml and
template_native_build.yml). They exist on main; this change adds none
(GATE-007 for the new lane is clean). Fixing them is separate infrastructure work.

Refs #1793. Does not close it — rules 3, 4, 6 remain.

The local gate gains a lane that runs the repository's full RUST-032 lint
phase as one command: soldr lint rust --cross-dylint. It runs rustfmt,
Clippy for the host and every target in [workspace.metadata.soldr].targets,
and Dylint per target, all from this Linux host.

ci-attestations.yml declares rust/<target>/{clippy,dylint} for all eight
declared targets on that lane, so one successful run attests per-target
coverage instead of a single host-only gate.

The lane is opt-in (--lane lint) until a warm run is measured at the
policy's max(30 s, 10% of cold) bar; the full gate run keeps its current
lane set so existing runs do not get slower.

Refs #1793
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 6150964 Oct 30, 2026
29 checks passed
@zackees

zackees commented Oct 30, 2026

Copy link
Copy Markdown
Member Author

Cold-run measurement attempt on a Linux host (post-merge evidence)

Merged as 6150964. Recording the measurement this PR asked for, and why it could
not be completed on the steward host.

Environment: Linux 6.18.48 (NixOS), 16 cores, loadavg 14.3 at t0, soldr 0.9.44.

Run 1 — soldr lint rust --cross-dylint, cold:

  • rustfmt and workspace Clippy checks the host targets and finishes:
    Finished dev profile [unoptimized + debuginfo] target(s) in 32.55s
    (soldr: cache 30 HIT, 169 MISS).
  • Then it aborts on the aarch64-unknown-linux-musl pass:
    blake3@1.8.7: c/blake3_neon.c:3:10: fatal error: arm_neon.h: No such file or directory
    -> error: failed to run custom build command for blake3 v1.8.7
    -> clippy failed for target aarch64-unknown-linux-musl
  • Wall 47.72 s, rc 101.

Run 2 — after soldr prepare --target aarch64-unknown-linux-musl (rc 0, "done",
dispatch=blessed-linux): fails identically. The build script still invokes
CC=/run/current-system/sw/bin/cc (the host compiler) for the aarch64 target, so
arm_neon.h is still missing. Wall 69.09 s, rc 101.

Conclusion for RUST-033 rule 6: no cold/warm pair is obtainable on this host
without an aarch64 C cross toolchain that soldr's prepare exports as CC_<triple>.
Any crate with a C dependency (blake3 here) blocks the cross-musl legs. The lane
therefore stays opt-in and the measurement stays open; the hosted lint job
family runs inside the builder image that carries those toolchains, which is why CI
was green.

Logs: ~/dev/hermes/cache/scratch/lint-cold.log, lint-cold2.log (steward host).
Follow-up worth filing: soldr lint rust --cross-dylint should either prepare each
target's C compiler or name the missing one instead of failing inside a dep's build
script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant