Repository navigation
ci(lint): add RUST-033 lint lane (soldr lint rust --cross-dylint) - #1795
Conversation
The local gate gains a lane that runs the repository's full RUST-032 lint
phase as one command: soldr lint rust --cross-dylint. It runs rustfmt,
Clippy for the host and every target in [workspace.metadata.soldr].targets,
and Dylint per target, all from this Linux host.
ci-attestations.yml declares rust/<target>/{clippy,dylint} for all eight
declared targets on that lane, so one successful run attests per-target
coverage instead of a single host-only gate.
The lane is opt-in (--lane lint) until a warm run is measured at the
policy's max(30 s, 10% of cold) bar; the full gate run keeps its current
lane set so existing runs do not get slower.
Refs #1793
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Cold-run measurement attempt on a Linux host (post-merge evidence)Merged as 6150964. Recording the measurement this PR asked for, and why it could Environment: Linux 6.18.48 (NixOS), 16 cores, loadavg 14.3 at t0, Run 1 —
Run 2 — after Conclusion for RUST-033 rule 6: no cold/warm pair is obtainable on this host Logs: |
Adopts fleet policy RUST-033 (forge-ci/ci.yml#511, #512) for FastLED/fbuild — first slice.
What this adds
A local-gate lane named
lintthat runs the repository's full RUST-032 lintphase as one command:
That covers rustfmt, Clippy for the host and for every target in
[workspace.metadata.soldr].targets(all eight), plus Dylint per target via--cross-dylintusing the lint libraries' pinned nightly. Cross targets lintfrom the Linux host through soldr's prebuilt
rust-std, so no nativeWindows/macOS machine is needed. A non-Linux host is a hard error rather than a
silent reduction in coverage.
ci-attestations.ymlnow declaresrust/<target>/{clippy,dylint}for all eightdeclared targets on the
lintlane, so one successful lane run attestsper-target coverage instead of a single host-only gate.
ci.tomllists the newlane;
ci/local_gate.pydispatches--lane lint.New files:
ci/local_lint_gate.py,ci/test_local_lint_gate.py(registered inci-workflow-drift.ymland the gate's own unittest list).Deliberately opt-in for now
--lane lintis not part of the defaultlocal-gate runyet. RUST-033 rule 6makes a mandatory lane conditional on a warm re-run costing at most
max(30 s, 10% of cold). This change has not measured that, and the cold pass over
eight targets plus Dylint is long. Flipping
lane == "lint"tolane in (None, "lint")is a one-line follow-up once the numbers exist. Thelintlane is additive: existing lane behaviour is unchanged.Not done here (needs upstream or owner action)
check-pushrefusing an unattested head"whatever the gate's mode", and merge-queue requiring a Dylint attestation,
are
ci-lintbehaviours; the pinnedci-linthas no mandatory-lane conceptand its gate definition only carries
lane/fidelity. Needs a ci.yml change,then wiring here. The lane and its gates are the prerequisite.
lint/Dylint check onmainis arepository-settings change only the owner can make.
lintlane.Static gate state
ci-lint local-gate linton this branch reports 14 pre-existing violations(replay dependency coverage for
ci-minimal.yml/dylint.yml, missingverifyneeds in
ci-minimal.yml, and barecargo/rustupinhw-ci.ymlandtemplate_native_build.yml). They exist onmain; this change adds none(GATE-007 for the new lane is clean). Fixing them is separate infrastructure work.
Refs #1793. Does not close it — rules 3, 4, 6 remain.