Skip to content

fix(esp32): reject framework = espidf instead of silently building Arduino (#1664) - #1730

Merged
zackees merged 1 commit into
mainfrom
fix/1664-reject-bare-espidf
Oct 25, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/1664-reject-bare-espidf

Conversation

@zackees

@zackees zackees commented Oct 25, 2026

Copy link
Copy Markdown
Member

Refs #1664. This PR covers the reject half of "honor or reject".

Change

  • framework = espidf without arduino is now rejected before any build work. The new reject_unsupported_esp_framework runs next to the existing sdkconfig-overlay guard at the top of the ESP32 orchestrator, and the error names fix(esp): honor or reject IDF framework requests instead of silently building Arduino #1664. fbuild has no CMake/idf.py build, so a bare-IDF project (app_main(), no setup()/loop()) previously went through the Arduino pipeline and reported success.
  • arduino, espidf still builds: Arduino-on-IDF links the same SDK and is legitimate coverage. It now logs a warning that this is not an IDF component build. Rejecting it would break FastLED's passing esp32dev_idf5_component job.

Verification

  • Unit tests. Bare espidf is rejected; arduino, arduino, espidf and espidf, arduino are accepted.
  • Checks. The fbuild-build-esp tests pass, workspace clippy with -D warnings is clean, and the platform-boundary inventory check passes.
  • Real build. fbuild build on an esp32dev project with framework = espidf exits 1 with the error before resolving packages.
  • Blast radius. No fbuild test project and no FastLED ci/boards.py board uses a bare espidf framework.

Still open on #1664

  • Recording the requested and effective framework in build_info.json.
  • FastLED's ci/boards.py comment on ESP32DEV_IDF5_COMPONENT says that leg exercises idf_component_register()/CMake. Under fbuild it does not. The comment should be corrected, or that leg run on PlatformIO, if real component coverage is wanted.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between e568cbf and 7d625b5.

Files selected for processing: 3
  • crates/fbuild-build-esp/src/esp32/orchestrator/build.rs
  • crates/fbuild-build-esp/src/esp32/orchestrator/helpers.rs
  • crates/fbuild-build-esp/src/esp32/orchestrator/tests.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…duino (#1664)

fbuild builds ESP32 projects only through the Arduino core and its
precompiled IDF libraries. A bare espidf project (app_main, no setup/loop)
was built as Arduino and reported success. Reject it before any build work,
and warn that 'arduino, espidf' is an Arduino-on-IDF build, not an IDF
component build.
@zackees
zackees force-pushed the fix/1664-reject-bare-espidf branch from e1dd18d to 7d625b5 Compare October 25, 2026 05:21
@zackees
zackees merged commit 8088892 into main Oct 25, 2026
30 checks passed
@zackees
zackees deleted the fix/1664-reject-bare-espidf branch October 25, 2026 05:34
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant