Repository navigation
fix(esp32): reject framework = espidf instead of silently building Arduino (#1664) - #1730
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…duino (#1664) fbuild builds ESP32 projects only through the Arduino core and its precompiled IDF libraries. A bare espidf project (app_main, no setup/loop) was built as Arduino and reported success. Reject it before any build work, and warn that 'arduino, espidf' is an Arduino-on-IDF build, not an IDF component build.
zackees
force-pushed
the
fix/1664-reject-bare-espidf
branch
from
October 25, 2026 05:21
e1dd18d to
7d625b5
Compare
This was referenced Oct 26, 2026
Merged
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1664. This PR covers the reject half of "honor or reject".
Change
framework = espidfwithoutarduinois now rejected before any build work. The newreject_unsupported_esp_frameworkruns next to the existing sdkconfig-overlay guard at the top of the ESP32 orchestrator, and the error names fix(esp): honor or reject IDF framework requests instead of silently building Arduino #1664. fbuild has no CMake/idf.pybuild, so a bare-IDF project (app_main(), nosetup()/loop()) previously went through the Arduino pipeline and reported success.arduino, espidfstill builds: Arduino-on-IDF links the same SDK and is legitimate coverage. It now logs a warning that this is not an IDF component build. Rejecting it would break FastLED's passingesp32dev_idf5_componentjob.Verification
espidfis rejected;arduino,arduino, espidfandespidf, arduinoare accepted.fbuild-build-esptests pass, workspace clippy with-D warningsis clean, and the platform-boundary inventory check passes.fbuild buildon anesp32devproject withframework = espidfexits 1 with the error before resolving packages.ci/boards.pyboard uses a bareespidfframework.Still open on #1664
build_info.json.ci/boards.pycomment onESP32DEV_IDF5_COMPONENTsays that leg exercisesidf_component_register()/CMake. Under fbuild it does not. The comment should be corrected, or that leg run on PlatformIO, if real component coverage is wanted.