Skip to content

fix(rp2350): preserve UF2 rejection diagnostics - #1246

Merged
zackees merged 1 commit into
mainfrom
fix/rp2350-uf2-diagnostics
Aug 2, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/rp2350-uf2-diagnostics

Conversation

@zackees

@zackees zackees commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary

  • retain picotool and mass-storage diagnostics when RP-series deployment exhausts both transports
  • probe the managed picotool for bounded UF2 diagnostic output after a BOOTSEL eject timeout
  • preserve the real primary/fallback ordering for both transport configurations

Validation

  • RED: new diagnostic helpers/tests failed before implementation
  • GREEN: soldr cargo test -p fbuild-deploy (269 passed, 13 hardware-only ignored)
  • soldr cargo clippy -p fbuild-deploy --all-targets -- -D warnings
  • attached hardware reproduced a rejected RP2350 image against an unrelated RP2040 BOOTSEL device and now reports both failed transports plus: ERROR: RP2350 command cannot be used with a non RP2350 device

Coordinated with FastLED/FastLED#3832.

Fixes #1245

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e7d30a36-4289-4831-b9bb-85cd5f3af2d6

📥 Commits

Reviewing files that changed from the base of the PR and between 5a42f4a and dd124c3.

📒 Files selected for processing (2)
  • crates/fbuild-deploy/src/rp2040.rs
  • crates/fbuild-deploy/src/rp2040_picotool.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 2c6ef53 into main Aug 2, 2026
93 checks passed
@zackees
zackees deleted the fix/rp2350-uf2-diagnostics branch August 2, 2026 07:11
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

fix(rp2350): preserve dual-transport and ROM UF2 rejection diagnostics

1 participant