Skip to content

Finish native app migration shims - #83

Merged
zackees merged 1 commit into
mainfrom
feat/native-build-backend
May 14, 2026
Merged

zackees merged 1 commit into
mainfrom
feat/native-build-backend

Conversation

@zackees

@zackees zackees commented May 14, 2026

Copy link
Copy Markdown
Member

Closes #72

Summary

  • Renames the Rust CLI binary to fastled-rs[.exe] during the migration while restoring fastled as the Python compatibility entry point.
  • Removes the Rust build fallback to python -m fastled.app; native build failures now surface directly.
  • Prevents Python shim recursion by resolving only fastled-rs, and passes a real Python executable into embedded PyO3 builds so Emscripten helpers do not invoke fastled-rs.exe as Python.
  • Documents remaining Python wrapper/holdout modules and adds regression tests for the native-first app path.
  • Updates issue Port the remaining Python app orchestration layer to Rust #72 with the directive to promote fastled-rs[.exe] back to fastled[.exe] once the migration is complete.

Parallel agent work

  • Build bridge stream removed the subprocess fallback and tightened Rust build behavior.
  • Python wrapper stream documented compatibility/holdout modules and added post-migration assertions.
  • CLI packaging stream renamed the Rust binary and updated wheel/install/CI staging.

Test plan

  • bash lint
  • bash test
  • uv run pytest -q -s tests/unit/test_cli.py::MainTester::test_command
  • uv run fastled --version
  • tasklist /FI "IMAGENAME eq fastled.exe" /NH
  • tasklist /FI "IMAGENAME eq fastled-rs.exe" /NH

@zackees
zackees merged commit 1bbf488 into main May 14, 2026
20 of 25 checks passed
@zackees
zackees deleted the feat/native-build-backend branch November 5, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port the remaining Python app orchestration layer to Rust

1 participant