Repository navigation
build: align rustc wrapper on zccache; drop redundant sccache from CI (closes #75) - #79
Merged
Merged
Conversation
Closes #75. ci/env.py::_apply_sccache previously set RUSTC_WRAPPER=sccache when sccache was on PATH, but the project uses zccache (via soldr) for compile caching. Renamed to _apply_rustc_wrapper and made it prefer zccache, falling back to sccache. The function is currently unimported elsewhere in the repo, so this is defensive for any future direct caller (e.g. ad-hoc cargo invocations that consume build_env()). CI workflows installed BOTH mozilla-actions/sccache-action and zackees/setup-soldr, then set RUSTC_WRAPPER=sccache. With every script caller now routing through soldr cargo (the soldr-managed zccache is wired automatically), the sccache half is redundant. Drop SCCACHE_GHA_ENABLED, RUSTC_WRAPPER: sccache, and the sccache-action step from _build.yml / _lint.yml / _unit-test.yml / _integration-test.yml. setup-soldr remains, providing zccache plus GitHub Actions cache for its state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks done
zackees
added a commit
that referenced
this pull request
May 13, 2026
Soldr (via zccache) is the project's compile cache. The sccache fallback in ci/env.py::_apply_rustc_wrapper was carried forward from the pre-soldr era; with PR #79 (closing #75) it no longer serves a purpose. Remove the fallback so RUSTC_WRAPPER points only at zccache when set. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 of 3 tasks
zackees
added a commit
that referenced
this pull request
May 13, 2026
#81) * build: drop sccache fallback; zccache is the only compile cache Soldr (via zccache) is the project's compile cache. The sccache fallback in ci/env.py::_apply_rustc_wrapper was carried forward from the pre-soldr era; with PR #79 (closing #75) it no longer serves a purpose. Remove the fallback so RUSTC_WRAPPER points only at zccache when set. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * ci(lint): install rustfmt/clippy via rustup; relax test_version assert Closes the two CI regressions that PR #80 surfaced on main: 1. **Lint job missing rustfmt and clippy.** zackees/setup-soldr@v0 reads only the channel from rust-toolchain.toml; the components array (["clippy", "rustfmt"]) is ignored. With the minimal profile, cargo fmt fails: error: 'cargo-fmt' is not installed for the toolchain Provision them explicitly via rustup component add after setup-soldr. Soldr itself does not yet expose component management — its CLI runs tools from the active toolchain but doesn't install missing components. 2. **test_version.py expects bare version string.** The Rust CLI (clap) emits 'fastled 2.0.7' for --version, matching the standard '<bin> <version>' format. The Python-era argparse emitted just '2.0.7'. Switch from assertEqual to assertIn so the package version is verified to be present without prescribing the exact format. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #75. Companion to #76 (PR #78, already merged).
Two remaining items from #75 after PR #78 retired the
_cargotrampolines:ci/env.py::_apply_sccachesetRUSTC_WRAPPER=sccachewhen sccache was on PATH, but this project uses zccache (via soldr). Renamed to_apply_rustc_wrapper; prefer zccache, fall back to sccache. The helper currently has no in-tree callers but is defensive for any future direct caller that buildscargoenv frombuild_env().CI workflows installed BOTH
mozilla-actions/sccache-action@v0.0.9ANDzackees/setup-soldr@v0, then setRUSTC_WRAPPER: sccachevia env. With every script caller now routing throughsoldr cargo(which manages the zccache wrapper automatically), the sccache half is redundant. DroppedSCCACHE_GHA_ENABLED,RUSTC_WRAPPER: sccache, and the sccache-action step from_build.yml,_lint.yml,_unit-test.yml,_integration-test.yml.setup-soldrremains and provides zccache + GitHub Actions cache for its state.Files
ci/env.py,.github/workflows/_build.yml,.github/workflows/_lint.yml,.github/workflows/_unit-test.yml,.github/workflows/_integration-test.ymlTest plan
bash lint— green; goes throughsoldr cargo fmt+soldr cargo clippygrep -rn 'sccache\|SCCACHE' .github/workflows/ ci/env.pyshows only the docstring/code fallback in_apply_rustc_wrapper— no more workflow references_lint,_unit-test,_build,_integration-testworkflows hit zccache cache hits (visible in soldr session log)Related
_cargotrampolines, added the PreToolUse hook🤖 Generated with Claude Code