Repository navigation
feat: stream live compilation output to Tauri viewer via SSE (#43) - #53
Merged
Merged
Conversation
Route the Tauri viewer path through compile_and_serve() so it uses the same Rust HTTP server + SSE infrastructure as the browser path. The viewer now shows real-time compilation output instead of a blank screen until compilation finishes. Key changes to main.rs: - Add ViewerMode enum (Browser | TauriViewer) to control display target - compile_and_serve() accepts ViewerMode and launches the appropriate viewer (browser or Tauri) before compilation begins - Remove the old Tauri compile-then-launch flow from main() - Simplify rebuild_python_args() by removing the tauri_viewer parameter - Remove unused output_dir_from_cli() helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ViewerModeenum (Browser/TauriViewer) tocompile_and_serve()--app(Tauri) and default (browser) paths now route through the same SSE-streaming compile+serve infrastructurerebuild_python_args()— removed the now-unnecessarytauri_viewerparameterWhat changed
The Tauri viewer previously compiled FIRST (with no user-visible progress), THEN opened. Now it opens immediately, shows the loading page with SSE log streaming, and auto-reloads when compilation completes — identical to the browser experience.
Test plan
cargo test -p fastled-cli— 58 tests passcargo fmt/cargo clippycleanCloses #43