Repository navigation
Phase 2b: Port file watching to Rust - #31
Merged
Merged
Conversation
Add crates/fastled-cli/src/watcher.rs implementing FileWatcher backed by the notify-7 crate. Mirrors the Python filewatcher.py behaviour: recursive directory watching, ignored-segment filtering (fastled_js, .build, __pycache__, .git, etc.), SHA-256 hash-based change deduplication, and a 300 ms debounce window. Seven unit tests cover hash stability, ignored-path filtering, event detection, and debounce coalescing. Wire in via `mod watcher` in main.rs (not yet integrated into CLI flow). Add `watch_available` PyO3 stub to fastled-py so Python can probe native-watcher support.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/fastled-cli/src/watcher.rs— a Rust file watcher backed by thenotify-7crate, porting the core logic fromsrc/fastled/filewatcher.pyfastled_js,.build,__pycache__,.git, etc.), deduplicates events via SHA-256 content hashing, and debounces rapid bursts (default 300 ms window)watch_available() -> boolPyO3 stub infastled-pyso Python can probe native-watcher availabilityCloses #19
Test plan
./_cargo build --workspace— compiles clean./_cargo test --workspace— 7 new Rust tests pass (hash stability, ignored-path filtering, event detection, debounce coalescing)./_cargo clippy --workspace --all-targets -- -D warnings— no warnings./_cargo fmt --all --check— cleanbash lint— all checks pass (ruff, black, isort, pyright, clippy, fmt)bash test— all 121 Python tests pass