Repository navigation
feat(dwarf): bridge source maps to debug sources - #132
Merged
Merged
Conversation
zackees
force-pushed
the
feat/dwarf-stack-trace-bridge
branch
from
June 1, 2026 20:11
8a91c84 to
87a39d1
Compare
Closed
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #130, #129, #85.
This PR lands the fastled-wasm side of the browser DWARF/source bridge:
-ffile-prefix-mapflags for sketch, FastLED, and emsdk roots using the[dwarf]prefixes frombuild_flags.tomlfastled.wasm.map/fastled.js.mapintofastled_js/, and removes stale maps when a later build does not produce themfastled_js/dwarf-roots.jsonafter successful builds and lets--serve-dirrehydrate the guarded debug source resolver from itsketchsource/Blink.ino, FastLED prefix-map paths, emsdk paths, and browser-normalized variants through the existing/dwarfsourceresolver/dwarfsourcehrefmanifests and restores executable bits after extractionNotes
This pairs with FastLED/FastLED#2675, which landed the FastLED-side wasm prefix-map support. I am not closing #130 from the PR alone; final issue closure still needs the browser null-deref acceptance check against the merged code.
Test plan
soldr cargo test -p fastled-cli debug_symbolssoldr cargo test -p fastled-cli wasm_buildsoldr cargo test -p fastled-cli serversoldr cargo test -p fastled-clisoldr --no-cache cargo test -p fastled-cli install::testsbash lintbash testfastled --internal-dwarf-smoke --debug --no-interactive ./Blinkresolved 136 embedded source paths via/dwarfsourceLinux x86 DWARF Smoke