Skip to content

refactor: move all HTTP clients behind kernal-api #238

Closed

Description

@zackees

Context

Refs #229. After archive adoption, reqwest remains directly used in archive.rs downloads; install.rs GitHub metadata, HEAD probes and extension downloads; project.rs release lookup; dwarf_smoke.rs async debug POSTs; and server.rs HTTP/SSE integration tests. download_to_path currently buffers the entire response, while archive::download streams without an explicit byte ceiling.

Proposal

Adopt the bounded HTTP client capability tracked at forge-ci/kernal-api#167. Keep FastLED URLs, User-Agent/Accept choices, release JSON interpretation, fallback-to-master behavior, SSE protocol assertions, and installation publication here. Remove direct reqwest declarations/imports including test code when all callers migrate.

Acceptance criteria

  • RED boundary and focused caller regression before implementation, then GREEN.
  • Stream downloads with explicit artifact limits; bound metadata and debug bodies separately.
  • Preserve GET/HEAD/POST/status/header behavior and async SSE coverage without moving FastLED protocol tests upstream.
  • Move generic HTTP client mechanism tests to kernel; no second HTTP implementation in the application.
  • Default/headless Rust, Python, lint and supported-platform integration checks pass against an exact published kernel release; no release path patch.

Decisions

  • HTTP client migration only; axum/tower server capability migration is separately tracked work in the overall inventory.
  • Small metadata and large artifact policies remain explicit at application call sites.
  • No issue closure based on blocking downloads alone: async debug and server tests also depend on reqwest.

Related issues

#229; forge-ci/kernal-api#167.

Activity

  1. zackees commented on Sep 13, 2026

    @zackees
    MemberAuthor

    Local migration update: archive downloads, install/project release metadata, HEAD probes, and extension downloads now use the kernel HTTP facade. The reqwest blocking feature is removed. The async DWARF smoke request has also been migrated locally to kernel HTTP/runtime APIs; reqwest is now only a dev-dependency for server integration tests, which still need migration before this issue is complete. Full Rust suite and strict Clippy passed for the DWARF code change; an additional end-to-end local source-smoke regression is being checked. Kernel HTTP remains an unreleased draft in the sibling checkout, so no release/path-patch completion claim is made.

  2. zackees commented on Sep 13, 2026

    @zackees
    MemberAuthor

    Depends on forge-ci/kernal-api#169, now open with platform CI running. The HTTP draft now has local TLS trust/hostname/downgrade mutation-tested coverage and an exact audited Hyper parser pin with metadata regressions. FastLED adopted Hyper 1.11.0 in the lockfile; all 255 Rust tests, strict all-target Clippy and three boundary tests pass. Direct reqwest remains absent. Kernel publication and removal of the temporary path override remain required before release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions