You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor: move all HTTP clients behind kernal-api #238
Refs #229. After archive adoption, reqwest remains directly used in archive.rs downloads; install.rs GitHub metadata, HEAD probes and extension downloads; project.rs release lookup; dwarf_smoke.rs async debug POSTs; and server.rs HTTP/SSE integration tests. download_to_path currently buffers the entire response, while archive::download streams without an explicit byte ceiling.
Proposal
Adopt the bounded HTTP client capability tracked at forge-ci/kernal-api#167. Keep FastLED URLs, User-Agent/Accept choices, release JSON interpretation, fallback-to-master behavior, SSE protocol assertions, and installation publication here. Remove direct reqwest declarations/imports including test code when all callers migrate.
Acceptance criteria
RED boundary and focused caller regression before implementation, then GREEN.
Stream downloads with explicit artifact limits; bound metadata and debug bodies separately.
Preserve GET/HEAD/POST/status/header behavior and async SSE coverage without moving FastLED protocol tests upstream.
Move generic HTTP client mechanism tests to kernel; no second HTTP implementation in the application.
Default/headless Rust, Python, lint and supported-platform integration checks pass against an exact published kernel release; no release path patch.
Decisions
HTTP client migration only; axum/tower server capability migration is separately tracked work in the overall inventory.
Small metadata and large artifact policies remain explicit at application call sites.
No issue closure based on blocking downloads alone: async debug and server tests also depend on reqwest.
Local migration update: archive downloads, install/project release metadata, HEAD probes, and extension downloads now use the kernel HTTP facade. The reqwest blocking feature is removed. The async DWARF smoke request has also been migrated locally to kernel HTTP/runtime APIs; reqwest is now only a dev-dependency for server integration tests, which still need migration before this issue is complete. Full Rust suite and strict Clippy passed for the DWARF code change; an additional end-to-end local source-smoke regression is being checked. Kernel HTTP remains an unreleased draft in the sibling checkout, so no release/path-patch completion claim is made.
Depends on forge-ci/kernal-api#169, now open with platform CI running. The HTTP draft now has local TLS trust/hostname/downgrade mutation-tested coverage and an exact audited Hyper parser pin with metadata regressions. FastLED adopted Hyper 1.11.0 in the lockfile; all 255 Rust tests, strict all-target Clippy and three boundary tests pass. Direct reqwest remains absent. Kernel publication and removal of the temporary path override remain required before release.
Activity
zackees commentedon Sep 13, 2026
Local migration update: archive downloads, install/project release metadata, HEAD probes, and extension downloads now use the kernel HTTP facade. The reqwest blocking feature is removed. The async DWARF smoke request has also been migrated locally to kernel HTTP/runtime APIs; reqwest is now only a dev-dependency for server integration tests, which still need migration before this issue is complete. Full Rust suite and strict Clippy passed for the DWARF code change; an additional end-to-end local source-smoke regression is being checked. Kernel HTTP remains an unreleased draft in the sibling checkout, so no release/path-patch completion claim is made.
zackees commentedon Sep 13, 2026
Depends on forge-ci/kernal-api#169, now open with platform CI running. The HTTP draft now has local TLS trust/hostname/downgrade mutation-tested coverage and an exact audited Hyper parser pin with metadata regressions. FastLED adopted Hyper 1.11.0 in the lockfile; all 255 Rust tests, strict all-target Clippy and three boundary tests pass. Direct reqwest remains absent. Kernel publication and removal of the temporary path override remain required before release.
feat: route archive downloads through kernel HTTP (refs #238)
feat: migrate blocking HTTP callers to kernel (refs #238)
feat: migrate DWARF HTTP and remove production reqwest (refs #238)
refactor: remove direct reqwest dependency via kernel HTTP tests
docs: record HTTP review fixes and validation (refs #238)
docs: record deterministic HTTP TLS validation (refs #238)
build: adopt audited kernel HTTP parser (refs #238)