Skip to content

feat: enforce NormalizedPath wrapper + ban raw PathBuf via dylint #117

Closed

Description

@zackees

Context

Issue #114 surfaced a class of bug where fs::canonicalize returned Windows long-path form (\?\C:\...) and that prefix leaked into external tools (meson, Python's open()) which then crashed. We strip the prefix in wasm_build::normalize_path, but only at the one site that triggered the crash. Any new PathBuf::from(canonicalize(...)) call elsewhere reintroduces the bug.

zccache solved this systematically: a NormalizedPath wrapper that handles `?\ regression cannot recur.

  • Existing tests still pass.

Refs

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions