You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
perf(ci): cache-key-suffix is per-job, defeating cross-job foundation cache reuse #106
These 4 jobs all compile the same Rust workspace from the same commit on the same OS — but the per-job/per-workflow prefix forces 4 separate cache entries instead of 1 shared foundation cache. Same anti-pattern as fastled/fbuild#280 fixed there.
Each cache entry under the v0.9.17+ defaults is ~250 MiB (build-cache + cook). At 4 jobs × per-OS × per-commit-shaped key noise, the action's 10 GB Actions LRU budget churns hard, and warm hits across the 4 jobs are lost.
Proposed fix
Drop the per-job + per-workflow components from the suffix. Use only the OS distinction:
cache-key-suffix: ${{ inputs.runs-on }}
Apply the same change to the INPUT_CACHE_KEY_SUFFIX env shim used in those files until the modern hyphenated form is the only path needed (v0.9.x reads either, so the env shim can also be dropped if you want).
Expected impact
Cache footprint on this repo: ~4× → 1×.
Warm cache hits: 4 jobs share the same content-addressed zccache state instead of starting cold off each other's saves.
Mirrors the ~6.7 GB → ~437 MiB result fbuild measured under the same fix.
Setup-soldr v0.9.17 also added cache-preset: foundation if you want to consolidate the per-input config (build-cache + prebuild-deps + cargo-registry-cache) into a single line at the same time.
Activity