Repository navigation
fix(net): stabilize RP2350W peer lifecycle - #3954
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe changes improve autoresearch network execution and deployment handling. They add configurable RPC wait limits, correct empty deploy-port parsing, add RP2350W listen retries, and improve ESP32 HTTP server startup cleanup. ChangesAutoresearch reliability
Estimated code review effort: 3 (Moderate) | ~25 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FBUILD_DEPLOY_PORT=marker as no port instead of parsing the following semicolonCloses #3953
Progresses #3832
Validation
bash lintbash lint ci/util/fbuild_runner.py ci/tests/test_fbuild_deploy_streaming.pybash lint ci/tests/test_rp2350w_board_config.pybash test fl_stl_asio_http_serverbash compile esp32c6 --examples AutoResearchbash compile rp2350w --examples AutoResearchHardware evidence and caveat
Before the final RP listener retry, the two-board HIL completed one full RP2350W <-> ESP32-C6 HTTP/RPC/4KiB/serial-health cycle; the next cycle exposed Arduino-Pico
WiFiServer::begin()silently failing to listen, which this patch now detects and retries.The next PICOBOOT deployment flashed successfully but the RP2350W runtime CDC endpoint did not return. COM18 is now an exact-serial phantom and Windows reports code 43 at the same direct root port, so final ten-cycle HIL is physically blocked pending recovery. That fbuild regression is recorded and deferred with restart criteria at FastLED/fbuild#1331; no raw flasher, ambiguous PnP reset, or hub/controller reset was attempted.
Summary by CodeRabbit