Skip to content

Several fixes including: allocate RootedValue for pyTypeFactory call on the stack instead of the heap - #234

Merged
philippedistributive merged 143 commits into
caleb/fix/thisfrom
philippe/pyTypeFactory-cleanup
Apr 3, 2024
Merged

philippedistributive merged 143 commits into
caleb/fix/thisfrom
philippe/pyTypeFactory-cleanup

Conversation

@philippedistributive

@philippedistributive philippedistributive commented Feb 1, 2024 •

Copy link
Copy Markdown
Contributor
  • memory leaks fixed involving the parameters to pyTypeFactory
  • added tests for globalThis and console.log
  • crash fix in JSObjectProxy_repr when have close to max recursion depth due to JS superclass structure such as in CryptoJS, with test added
  • cleanup: TODOs, added missing file headers, removed meaningless file versions, fixed incomplete or missing copyright headers
  • crash fix in DictType constructor, with test added
  • implemented array size expansion JS-style, for when a list index is referenced beyond the current length, for Lists, with added tests
  • added missing traverse and clear operations for JSObjectProxy, fixed traverse for JSArrayProxy
  • improved setdefault performance
  • removed no longer used 2nd pyTypeFactory parameter
  • updated firefox to latest esr release
  • implemented __class__ for both arrays and objects, changing the type name to make it appear we are indeed a list or a dict. This was queried by aiohttp
  • Proxies now use parent type name for enhanced type compatibility
  • Added testfor Array subclass behaving as Array
  • Fixed when a property key is shadowing a method

closes #199
closes #231
closes #306

-> depends on #227

@philippedistributive philippedistributive changed the title Memory Leak fixes: allocate RootedValue for pyTypeFactory call on the stack instead of the heap Several fixes including: allocate RootedValue for pyTypeFactory call on the stack instead of the heap Feb 6, 2024

@zollqir zollqir left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zollqir
zollqir force-pushed the philippe/pyTypeFactory-cleanup branch 2 times, most recently from 00cd684 to a2d818a Compare April 2, 2024 18:13
@philippedistributive
philippedistributive merged commit 00dfec4 into caleb/fix/this Apr 3, 2024
@philippedistributive
philippedistributive deleted the philippe/pyTypeFactory-cleanup branch April 3, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants