toString() might be broken sometimes #58

Activity

1. wesgarland commented on Jul 14, 2023

   

   wesgarland

   on Jul 14, 2023

   Collaborator

   More actions

   @wiwichips Would you might retesting against today's tip?
2. wiwichips commented on Jul 19, 2023

   

   wiwichips

   on Jul 19, 2023

   CollaboratorAuthor

   More actions

   @wiwichips Would you might retesting against today's tip?
   I don't remember what the tip was

   For what its worth I am still seeing this behaviour on newest PythonMonkey pull on main:

   package.json

   {
     "dependencies": {
       "crypto-js": "^4.1.1"
     }
   }

   main.py

   import pythonmonkey as pm
   CryptoJS = pm.require('crypto-js')
   cipher = CryptoJS.SHA256("Hello, World!").toString(() 
   print(cipher) # ''

   It prints the empty string, but it should print dffd6021bb2bd5b0af676290809ec3a53191dd81c7f70a4b28688a362182986f

   ---

   If I call toString() in JavaScript code and call that JavaScript code from Python it works as expected. So for examples like this I do something like this:

   sha256.js

   const CryptoJS = require("crypto-js");
   
   module.exports = function sha256(thing) {
     return CryptoJS.SHA256(thing).toString()
   }

   main.py

   import pythonmonkey as pm
   
   sha256 = pm.require("./sha256")
   
   print(sha256("Hello, World!")) # this outputs dffd6021bb2bd5b0af676290809ec3a53191dd81c7f70a4b28688a362182986f
3. philippedistributive commented on Jan 29, 2024

   

   philippedistributive

   on Jan 29, 2024

   Contributor

   More actions

   Repro should be
   $ npm install crypto-js
   $ touch main.js
   main.js:
   import pythonmonkey as pm
   CryptoJS = pm.require('crypto-js')
   cipher = CryptoJS.SHA256("Hello, World!").toString()
   print(cipher) # ''
4. philippedistributive

   closed this as completedin #224on Jan 31, 2024
5. philippedistributive

   assigned

   zollqir

   on Feb 1, 2024
6. philippedistributive

   added a commit that references this issue on Feb 2, 2024

   added test for issue #58

   324ad7a
7. philippedistributive

   linked a pull request that will close this issueCaleb/fix/this #227on Feb 6, 2024
8. philippedistributive

   removed a link to a pull requestCaleb/fix/this #227on Feb 6, 2024
9. zollqir

   added a commit that references this issue on Apr 2, 2024

   added test for issue #58

   bc08953