require crypto-js.js commonJS runing error #252

Activity

1. hjdhnx commented on Feb 29, 2024

   

   hjdhnx

   on Feb 29, 2024

   Author

   More actions

   from pythonmonkey import eval as js_eval, require as js_require
   CryptoJS = js_require('./crypto-js')
   text = CryptoJS.MD5('123456').toString()
   print('md5 text:',text)
   text = CryptoJS.enc.Base64.stringify(CryptoJS.enc.Utf8.parse('123456'))
   print('base64 text:',text) 
2. hjdhnx commented on Feb 29, 2024

   

   hjdhnx

   on Feb 29, 2024

   Author

   More actions

   
   it's the same as npm require
3. wesgarland commented on Feb 29, 2024

   

   wesgarland

   on Feb 29, 2024

   Last edited by wesgarland

   Collaborator

   More actions

   • I can reproduce this with crypto-js 4.2.0
   • I used npm to install crypto-js so I had to change the require to not have the ./
   • this works properly if done in pure JS from pmjs, so the problem must be related to JS<>Python layer

   npm init
   npm i crypto-js
   [~/test] dev-wes:wes# pmjs
   Welcome to PythonMonkey v0.3.0.
   Type ".help" for more information.
   > CryptoJS = require('crypto-js')
   ...
   > text = CryptoJS.MD5('123456').toString()
   'e10adc3949ba59abbe56e057f20f883e'
   > text = CryptoJS.enc.Base64.stringify(CryptoJS.enc.Utf8.parse('123456'))
   'MTIzNDU2'
   > 
   
4. wesgarland commented on Feb 29, 2024

   

   wesgarland

   on Feb 29, 2024

   Last edited by wesgarland

   Collaborator

   More actions

   ~ minimal test case

   npm init
   npm i crypto-js
   [~/test] dev-wes:wes# python3
   Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
   Type "help", "copyright", "credits" or "license" for more information.
   >>> from pythonmonkey import eval as js_eval, require as js_require
   >>> CryptoJS = js_require('crypto-js')
   >>> CryptoJS.enc.Base64.stringify(CryptoJS.enc.Utf8.parse('123456'))
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
   pythonmonkey.SpiderMonkeyError: Error in file evaluate, on line 59:
   TypeError: map is undefined
   Stack Trace: 
     stringify@evaluate:59:22
   
   >>> 
   
5. wesgarland commented on Feb 29, 2024

   

   wesgarland

   on Feb 29, 2024

   Collaborator

   More actions

   In crypto-js/enc-base64.js, I think this is blowing up on line 59 because this._map in the stringify method is undefined.

   This implies that PythonMonkey is invoking CryptoJS.enc.Base64.stringify with the wrong this
6. philippedistributive

   assigned

   zollqir

   on Feb 29, 2024
7. wesgarland commented on Feb 29, 2024

   

   wesgarland

   on Feb 29, 2024

   Collaborator

   More actions

   @hjdhnx - this is probably-fixed in PR 227. Stay tuned, I expect a new release in a week or two with that PR landed.
8. zollqir commented on Feb 29, 2024

   

   zollqir

   on Feb 29, 2024

   Last edited by zollqir

   Collaborator

   More actions

   I just tried @wesgarland's minimal test case on that branch, and it works great, so you have that to look forward to (as this is effectively a duplicate of #172) .
9. wesgarland commented on Feb 29, 2024

   

   wesgarland

   on Feb 29, 2024

   Collaborator

   More actions

   Confirmed fixed on main already as well - 0.3.1.dev39+67e65d0
10. hjdhnx commented on Mar 1, 2024

    

    hjdhnx

    on Mar 1, 2024

    Author

    More actions

    Confirmed fixed on main already as well - 0.3.1.dev39+67e65d0

    oh thank you for fix this bug, I test ok
    
11. hjdhnx commented on Mar 1, 2024

    

    hjdhnx

    on Mar 1, 2024

    Author

    More actions

    pythonmonkey-0.3.1.dev42+6b5fb9d-cp38-cp38-win_amd64.whl fixed this bug
12. hjdhnx

    closed this as completedon Mar 1, 2024