Skip to content

feat: Upgrade to bootstrap 5 - #22

Open
NickJ-7010 wants to merge 9 commits into
masterfrom
bootstrap-5
Open

NickJ-7010 wants to merge 9 commits into
masterfrom
bootstrap-5

Conversation

@NickJ-7010

Copy link
Copy Markdown

What

what the PR changes

  • Oh boy where to begin...
  • Added a proper README.md with running and setup instructions
  • Added a docker-compose.yaml so that the project can be built and run easily
  • Removed the HACKING folder and changed to a .env.example with updated env variables
  • Added a real header.tmpl for the nav bar and use it across the app
  • Updated the UI to use more bootstrap features and be
  • A lot of other small changes :P

Why

why these changes were made

I wanted to make some improvements to the functionality of plug but getting it running was a struggle as it was not at all setup for local development.

Test Plan

how did you verify these changes did what you expected

A lot of local testing and asking eboard members to sanity check me.

Env Vars

did you add, remove, or rename any environment variables

  • Renamed all of the csh auth env variables to be uppercase to follow conventions.
  • Added a S3 bucket env variable S3_BUCKET_NAME to let devs specify the name of their S3 bucket instead of just trying to use the prod one which is plugs.
  • Added an LDAP_WRITE_MODE env variable to allow for devs to disable the attempted ldap writes and crashing the backend.

Documentation

did you add or update any documentation. PRs should, at the minimum, update documentation when they make existing documentation out of date.

Made the README.md actually helpful for getting plug setup locally

Checklist

  • Tested all changes locally
  • Wrote this code wayyyyyy too late at night

@NickJ-7010
NickJ-7010 requested a review from a team October 10, 2026 08:19

@BigSpaceships BigSpaceships left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Comment thread .env.example Resolved

@BigSpaceships BigSpaceships left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W memba, few thoughts, btw you don't need to add s3 to local running, and if you do, you could also do anotehr pr if you want

Comment thread .env.example Resolved
Comment thread .env.example Resolved
Comment thread templates/upload.tmpl Outdated
<small id="numHelp" class="form-text
text-muted">Increase the number of credits to pay
for extended-air-time.</small>
<input class="form-control-file" id="fileUpload" name="fileUpload" aria-describedby="fileHelp" type="file">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image this is icky ):

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been adjusted to look better than it did before!

Comment thread docker-compose.yaml
test: ["CMD-SHELL", "pg_isready -U plug"]
interval: 5s
timeout: 5s
retries: 5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not gonna make you but you could add an s3 client :)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean like a lightweight s3 emulator in another container? Is this related to your review comment?

btw you don't need to add s3 to local running, and if you do, you could also do anotehr pr if you want

Comment thread s3.go Resolved
Comment thread docker-compose.yaml Resolved
Comment thread docker-compose.yaml
plug-postgres:
image: docker.io/postgres
container_name: plug-postgres
environment:

@datadog-computersciencehouse datadog-computersciencehouse Bot Nov 6, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 High: Hardcoded credential in service environment

Storing credentials such as passwords, API keys, or tokens as literal values in the `environment` section exposes them in version control, container inspect output, and process listings. Any developer, CI system, or atta... (...read more)

Storing credentials such as passwords, API keys, or tokens as literal values in the environment section exposes them in version control, container inspect output, and process listings. Any developer, CI system, or attacker with read access to the Compose file or the running container can retrieve the credential. Sensitive values should be passed via Docker secrets (secrets:) or referenced as environment variable placeholders (e.g., DB_PASSWORD: ${DB_PASSWORD}) rather than hardcoded literals.

Helpful? 👍/👎 View in Datadog  Leave us feedback  Documentation
🚩 Report as false positive. Flags the rule for review to improve detection accuracy.

@datadog-computersciencehouse

datadog-computersciencehouse Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

IaC  Code Quality  Code Vulnerabilities  Library Vulnerabilities  Secrets

⚠️ Warnings

🧱 1 Infrastructure as Code (IaC) issue detected

High: Hardcoded credential in service environment Hardcoded credential in service environment View rule
docker-compose.yaml:26

ℹ️ Info

No other issues found (see more)

🛠️ No new code quality issues
🛡️ No new code vulnerabilities
📚 No new vulnerable libraries detected
🔑 No new secrets detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4bb519b | Docs | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants