Repository navigation
feat: Upgrade to bootstrap 5 - #22
NickJ-7010 wants to merge 9 commits into
Conversation
…dditional README documentation
Co-authored-by: Noah Hanford <bigspaceships56@gmail.com>
BigSpaceships
left a comment
There was a problem hiding this comment.
W memba, few thoughts, btw you don't need to add s3 to local running, and if you do, you could also do anotehr pr if you want
| <small id="numHelp" class="form-text | ||
| text-muted">Increase the number of credits to pay | ||
| for extended-air-time.</small> | ||
| <input class="form-control-file" id="fileUpload" name="fileUpload" aria-describedby="fileHelp" type="file"> |
There was a problem hiding this comment.
It has been adjusted to look better than it did before!
| test: ["CMD-SHELL", "pg_isready -U plug"] | ||
| interval: 5s | ||
| timeout: 5s | ||
| retries: 5 |
There was a problem hiding this comment.
not gonna make you but you could add an s3 client :)
There was a problem hiding this comment.
do you mean like a lightweight s3 emulator in another container? Is this related to your review comment?
btw you don't need to add s3 to local running, and if you do, you could also do anotehr pr if you want
…oad card great again
| plug-postgres: | ||
| image: docker.io/postgres | ||
| container_name: plug-postgres | ||
| environment: |
There was a problem hiding this comment.
🔴 High: Hardcoded credential in service environment
Storing credentials such as passwords, API keys, or tokens as literal values in the `environment` section exposes them in version control, container inspect output, and process listings. Any developer, CI system, or atta... (...read more)
Storing credentials such as passwords, API keys, or tokens as literal values in the environment section exposes them in version control, container inspect output, and process listings. Any developer, CI system, or attacker with read access to the Compose file or the running container can retrieve the credential. Sensitive values should be passed via Docker secrets (secrets:) or referenced as environment variable placeholders (e.g., DB_PASSWORD: ${DB_PASSWORD}) rather than hardcoded literals.
Helpful? 👍/👎
🚩 Report as false positive. Flags the rule for review to improve detection accuracy.
|

What
what the PR changes
Why
why these changes were made
I wanted to make some improvements to the functionality of plug but getting it running was a struggle as it was not at all setup for local development.
Test Plan
how did you verify these changes did what you expected
A lot of local testing and asking eboard members to sanity check me.
Env Vars
did you add, remove, or rename any environment variables
S3_BUCKET_NAMEto let devs specify the name of their S3 bucket instead of just trying to use the prod one which isplugs.LDAP_WRITE_MODEenv variable to allow for devs to disable the attempted ldap writes and crashing the backend.Documentation
did you add or update any documentation. PRs should, at the minimum, update documentation when they make existing documentation out of date.
Made the README.md actually helpful for getting plug setup locally
Checklist