Repository navigation
roll up compile SDK, target SDK, Gradle, AGP, and most dependencies - #8
Open
NinjaCheetah wants to merge 7 commits into
Open
NinjaCheetah wants to merge 7 commits into
NinjaCheetah wants to merge 7 commits into
Conversation
Also rolls all dependencies up to latest to work towards an updated build of the app. Lots of things still broken, that's the next challenge.
Minimum SDK needs to be raised from 24 -> 26 because some libraries have a minimum of 26, and we can't be lower than that. 37 is just the current SDK so that makes sense for compile SDK.
DrinkList was using a Box and a PullToRefreshContainer, and the latter no longer exists. It now uses a PullToRefreshBox instead which is the modern way to implement that. Okta v3 introduced lots of breaking changes that I don't want to deal with right now, so back to v1.2.0 so that the app builds again. There are still bugs to fix, the app is still not usable and there are lots of warnings but a build is a step in the right direction.
From what I could tell, minify is only supposed to be on for the app target and not the shared target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolls up the following components to allow the app to be updated on the Play Store:
9.5.29.5.126(Android 8.0, required because some deps only support >=26)37com.okta.kotlin:auth-foundationand related components to the latest versions (there were a LOT of API changes here so rolling that up is beyond the scope for right now)To make that easier I also centralized dependency versions into a
libs.versions.tomland pointed all the plugins and libraries in the variousbuild.gradle.ktsfiles at it, because that seems like what Google wants you to do and that's what Android Studio set up for me when I created the TigerDine for Android project.After updating dependencies, I also had to make a couple of functional changes to make the app actually still work. Only two main ones though:
DrinkList.kt:PullToRefreshContainerwas removed, so I switched theBox+PullToRefreshContainerto aPullToRefreshBoxto make it work again.MainActivity.kt: I was running into an issue when it was decoding JWTs because it expected them to be padded and I guess they weren't? So now it pads them as needed and the app data loads again!I have not migrated from
kapttoKSP, so when I migrated to built-in Kotlin I switched it over to thekapt-legacyplugin so thatkaptstuff will keep working in the meantime.I had someone who actually has a Pixel install the app, and signing in/dropping drinks/NFC for Gatekeeper were all working as expected. This should be ready for a Play Store release!! (So Google won't kill our developer account!)
App version bumped to 39/2.2.0