Skip to content

Account: complete the email-change flow (verify and undo) #72

Closed

Description

@Adron

Part of #71 — Account lifecycle & security completeness

POST /api/user/change-email/request is wired, but the two endpoints that finish the flow are
not:

  • POST /api/auth/verify-email-change — confirm the new address from the emailed link.
  • POST /api/auth/undo-email-change — the safety valve if the change was not the user's doing.

Today an Android user can start an email change and then has to finish it on the web.

  • Deep-link handlers for both emailed links, plus an in-app pending-change state showing the
    address awaiting verification with resend and cancel.

Tests: deep-link parse for each; pending state renders and clears.


Filed from the parity review of feature/parity-wip @ 14d7795 against interlinedlist.com (OpenAPI /api/openapi.json, 233 paths) and the public help centre.

Activity

  1. added
    parityClosing a gap against interlinedlist.com
    P2Completeness / settings surface
    area:accountAccount, auth & security
    on Sep 15, 2026
  2. Adron commented on Sep 16, 2026

    @Adron
    MemberAuthor

    Implemented in the PR above (branch issue/72-account-email-change). Closing here — review and any follow-up happens on the PR.

    Two things need your confirmation, both carried into the PR:

    The emailed link URLs are derived, not documented. GET /verify-email-change?token=… and GET /undo-email-change?token=… both return 200 and render "Invalid Verification Link" / "Invalid Undo Link", while /auth/verify-email-change, /email-change/verify, /account/verify-email-change and /change-email all 404 — so the paths match the existing /verify-email and /reset-password convention. Please check against the actual mail templates.

    The "cancel" action this issue asked for does not exist in the API, so I did not ship a fake button. DELETE /api/user/change-email/request returns 405 (the route is POST-only), and POST /api/user/change-email/cancel, DELETE /api/user/change-email and a pendingEmail field on PATCH /api/user/update all 404 or are absent. The product's real safety valve is undo-email-change, which needs the token from the email — so the banner explains that instead of pretending to offer cancellation.

    Worth a separate look: the help page documents POST /api/user/change-email/request as { newEmail, password }, but the spec and the already-shipped ChangeEmailRequest send only newEmail. If the server really requires password, the existing change-email request is already broken — not something this issue introduced.

  3. added a commit that references this issue on Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Completeness / settings surfacearea:accountAccount, auth & securityparityClosing a gap against interlinedlist.com

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions