Conversation
…browser-wasm (CommunityToolkit#574) Use a Monitor lock for the synchronous lazy init, since SemaphoreSlim.Wait is unsupported on single-threaded browser-wasm. Adds regression tests.
AtakanUk
force-pushed
the
fix/574-offline-options-wasm-lock
branch
from
October 4, 2026 07:34
0de9ed9 to
9d5764d
Compare
Author
|
@dotnet-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #574
Problem
On .NET 11 single-threaded browser-wasm, blocking
SemaphoreSlim.Wait(marked[UnsupportedOSPlatform("browser")]) throws.OfflineDbContext.BuildDatasyncOfflineOptions()usedDisposableLock.AcquireLock(), which callsWait(). This broke offlinePullAsyncand push (viaOperationsQueueManager'sLazy<OfflineOptions>).Fix
Replace the
SemaphoreSlim-based lock with a plainlockon a private object. Noawaithappens inside the critical section, andMonitoris supported on single-threaded wasm. The_optionsLock.Dispose()call was removed accordingly.Tests
BuildDatasyncOfflineOptions_ReturnsSameInstanceBuildDatasyncOfflineOptions_ConcurrentCalls_BuildOnceNotes (not addressed here)
A CA1416 scan with
SupportedPlatform=browseralso flagsMD5.HashData(PullRequestBuilder),HttpClientHandler.AutomaticDecompression(HttpClientExtensions), the now test-only syncDisposableLock.AcquireLock, and the sync-over-asyncTask.Run(...).GetResult()inOperationsQueueManager.UpdateOperationsQueue. These could be follow-ups.