Skip to content

🐞 Key event should be released if text view lost focus or after relinquished first responder #57

Closed

Description

@neesonqk

https://github.com/CodeEditApp/CodeEditTextView/blob/9b300d8a37589f4e16719f98d1bf8763940ef0b2/Sources/CodeEditTextView/STTextViewController.swift#L182

Here, this line will be always executed whenever 'Tab' key is pressed, e.g. if the focus is on a other tab or command palette, all open tabs will insert a tab space.

textView?.insertText(String(repeating: " ", count: tabWidth))

Activity

  1. thecoolwinter commented on Sep 14, 2022

    @thecoolwinter
    Collaborator

    Good catch. This should be triggered in the delegate method textView(_ textView: STTextView, didChangeTextIn affectedCharRange: NSTextRange, replacementString: String).

  2. changed the title [-]Key event should be released if text view lost focus or after relinquished first responder[/-] [+]🐞 Key event should be released if text view lost focus or after relinquished first responder[/+] on Nov 22, 2022
  3. austincondiff commented on Feb 17, 2023

    @austincondiff
    Collaborator

    Can we confirm that this issue still exists?

  4. moved this from 🆕 New to 💬 Needs Clarification in CodeEdit Projecton Feb 17, 2023
  5. moved this from 💬 Needs Clarification to 🏁 Complete in CodeEdit Projecton Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions