Repository navigation
Start container scans from the CLI (0.5.16) #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harshit905
wants to merge
2
commits into
main
Choose a base branch
from
harshit/container-scan-start
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The deadline is checked only after this request returns, so a slow poll can finish after
--timeoutand prevent the CLI from exiting 4 on time.Assessment: 🟠
Major· 🔁Occurrence: Rarely· 🏷️Logic errorPrompt for AI Agent 🤖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CodeAnt-AI: While a scan is running, this poll only reads the scan meta.json and lists its repos/ prefix, and the API in front of it cuts requests off at about 60 s, so the overrun should be at most one short request. Is there a path where a single running-status poll could take much longer than that, enough to justify passing an AbortSignal through request() and fetchAppApi()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The normal running-scan path—reading scan metadata and listing repositories—shouldn’t take much longer than the API’s roughly 60-second cutoff, so there’s no known backend operation that would routinely cause a large overrun.
However, that cutoff isn’t a client-side deadline: a stalled connection could leave
fetchwaiting, and even a 60-second response exceeds a valid--timeout 1. A late response could also report completion after the deadline and be returned as success. Since--timeoutis documented as a maximum wait, I’d bound each poll by the remaining time with anAbortSignaland report exit 4 when that deadline expires. If the timeout is intended to be approximate, the signal plumbing isn’t necessary—but the docs should say an in-flight poll may overrun it.