Repository navigation
Conversation
…ations (CapSoftware#3563) Durations stored as fractional seconds between 59 and 60 seconds rendered as '60 secs' because minutes were floored before ceil-rounding remaining seconds. Ceil total seconds before computing minutes and hours so near-minute durations roll over into '1 min' consistently with mobile and neighboring values. Closes CapSoftware#3563
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3563
Linear: CAP-953
Video thumbnail cards on dashboards and public share cards were displaying "60 secs" for recordings with fractional durations between 59 and 60 seconds (such as 59.5s).
Root Cause
formatDurationinapps/web/components/VideoThumbnail.tsxcomputedtotalMinutes = Math.floor(duration.asMinutes)andremainingSeconds = Math.ceil(duration.asSeconds % 60). When duration was e.g.59.5s:totalMinuteswas floored to0remainingSecondswas ceil-rounded to60"60 secs"instead of rolling over to"1 min".Changes
formatDurationinapps/web/lib/date-format.tsand re-exported it fromVideoThumbnail.tsx.Math.max(0, Math.ceil(durationSecs))) before deriving hours, minutes, and remaining seconds, matching the calculation inapps/mobile/src/utils/format.ts."1 min".apps/web/__tests__/unit/video-thumbnail-duration.test.tscovering sub-minute, sub-second, multi-minute, and hour boundary formatting.Test plan
bun test apps/web/__tests__/unit/video-thumbnail-duration.test.ts(4 pass, 17 assertions)bun test apps/mobile/src/utils/format.test.ts(4 pass, 19 assertions)
This PR appears safe to merge.Summary
Fixes thumbnail duration labels by rounding total seconds up before choosing seconds, minutes, or hours.
Reviews (1) · Last reviewed commit: "fix(web): prevent video thumbnails showi..." · Reviewed by Greptile