Repository navigation
fix(web): prevent transcript drafts from disappearing during saves - #3503
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
3 tasks done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transcript edits typed while an earlier save was pending could disappear when that save completed. Another cue's editor could also be opened and then closed by the earlier request.
Pause text editing and cue edit buttons until the save settles. After a failed save, the existing draft remains available to retry or cancel.
Using the same delayed save:
66 focused transcript tests and two additional real-action/storage-boundary probes pass. Both loss reproductions and the pending-save regressions fail on baseline. Full workspace typecheck and scoped Biome pass. The regression already runs in the existing CI web-test step.
Tests mount the actual components in jsdom and use fixtures at auth, database and storage boundaries. No live browser/S3 session was exercised. Independent GPT-6 Astra HIGH review passed exact commit
3f756035e93569017b3d30b0312b053eab348c10, rerunning all 66 focused cases and both action/storage probes, plus seven additional checks for failed requests, retry/cancel, repeated clicks, cue seeking, refreshes and save-transition row updates.At 1,200 cues, the pending transition updates 1,199 other rows to disable their edit controls. Success already updates 1,200 rows in both versions; failure adds another 1,199 updates to restore controls. These are jsdom render counts, not browser latency measurements. Typing and cue-selection memoization remain covered.
Closes #3502.


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Pauses transcript editing while a save is pending so that completion cannot discard newer typing or close another cue’s editor.
No actionable issues found. Review was static; tests and browser checks were not run.
Acknowledged trade-off: AksharP5 documented extra row updates when save state changes, with render counts rather than browser latency measurements.
Reviews (1) · Last reviewed commit: "fix(web): prevent transcript drafts from..." · Reviewed by Greptile