Skip to content

Preparatory work for supporting "drafts" folder #1505

Closed

Description

@PeterSurda

class_singleWorker.py and class_singleCleaner.py don't filter all requests for folder = 'sent'. This would cause problems with having other folders (it probably already causes problems with trashed messages). Other files may also be affected.

Activity

  1. added
    developersThe issue is relevant mainly for developers rather than users
    on Aug 16, 2019
  2. navjotcis commented on Aug 16, 2019

    @navjotcis
    Contributor

    ok

  3. PeterSurda commented on Aug 16, 2019

    @PeterSurda
    MemberAuthor

    e.g.

    '''UPDATE sent SET status='msgqueued' WHERE toaddress=?''',
    '''UPDATE sent SET status='msgqueued' WHERE ackdata=?''',
    '''SELECT ackdata FROM sent WHERE status = 'msgsent' ''')
    'UPDATE sent SET ackdata=? WHERE ackdata=?',
    '''UPDATE sent SET status='broadcastqueued' '''
    '''UPDATE sent SET status='doingbroadcastpow' '''
    'UPDATE sent SET msgid=?, status=?, lastactiontime=?'
    '''UPDATE sent SET status='msgqueued' '''
    '''UPDATE sent SET status='doingmsgpow' '''
    '''UPDATE sent SET status='doingmsgpow' '''
    '''UPDATE sent SET status='awaitingpubkey', '''
    '''UPDATE sent SET '''
    '''UPDATE sent SET '''
    '''UPDATE sent SET status='toodifficult' '''
    '''UPDATE sent SET status='badkey' WHERE ackdata=?''',
    '''UPDATE sent SET msgid=?, status=?, retrynumber=?, '''
    '''SELECT retrynumber FROM sent WHERE toaddress=? '''
    '''UPDATE sent SET lastactiontime=?, '''

  4. g1itch commented on Aug 16, 2019

    @g1itch
    Collaborator

    The problem with sent is that it is not a folder but a separate table with own folders.

  5. PeterSurda commented on Aug 16, 2019

    @PeterSurda
    MemberAuthor

    @g1itch that should be ok to work with, otherwise a lot of refactoring is needed.

  6. added this to the v0.6.4 milestone on Aug 27, 2020
  7. navjotcis commented on Sep 19, 2020

    @navjotcis
    Contributor

    I am running kivy and QT app both but in kivy app, there is Draft message feature that is not in the QT app and the draft message is using same database table which sent message is using only folder field is used to differentiate which type of message it is. so in class_singleWorker.py and class_singleCleaner.py file there is no filter in the sent table on the bases of folder=' sent' so I have implemented all the queries of both files with filter folder=' sent' #1672

  8. PeterSurda commented on Nov 11, 2020

    @PeterSurda
    MemberAuthor

    Fixed in #1672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

developersThe issue is relevant mainly for developers rather than users

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions