Repository navigation
fix: apply workspace-scoped overrides on publish - #309
Merged
Alexander Zaslonov (azaslonov) merged 4 commits intoOct 5, 2026
Merged
Conversation
Previously the CLI applied overrides to the workspace container itself (the properties on the workspace entry), but silently ignored all nested child overrides (apis, backends, loggers, etc. within the workspace) Compatibility note: workspace-scoped resources that previously picked up a same-named top-level override will no longer do so. The new tests make that isolation intentional, but existing configs relying on the old behavior may publish different values.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Post-merge override checks still use service-level sections, causing some workspace API and named-value overrides to be altered or discarded.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Applies workspace-scoped overrides during publishing and aligns auto-generated named-value handling.
Changes:
- Resolves direct and nested overrides through workspace configuration.
- Updates named-value filtering and redaction checks.
- Adds workspace override tests and removes obsolete documentation.
| File | Description |
|---|---|
src/services/override-merger.ts |
Resolves workspace-scoped override sections. |
src/services/publish-service.ts |
Handles workspace named-value overrides. |
src/services/secret-redaction-guard.ts |
Aligns workspace named-value scanning. |
tests/unit/services/override-merger.test.ts |
Tests workspace override merging. |
tests/unit/services/publish-service.test.ts |
Tests auto-generated workspace named values. |
docs/guides/environment-overrides.md |
Removes the resolved limitation notice. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
@microsoft-github-policy-service agree |
Matthew Johnson (centreboard)
marked this pull request as ready for review
October 3, 2026 10:51
Tuan Nguyen (atuannguyen1101)
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace-scoped overrides were being parsed but silently ignored on publish for all child resources.
This fix applies them at the different nested levels during the publish, including for overrides of autogenerated named values
Fixes #118