bundle stage runs from any working directory (tsx --tsconfig); lock files uncommitted - #476
Merged
Merged
Conversation
… from any working directory; lock files uncommitted (#470) cli.ts imports its neighbours through the @/ alias and tsx resolved that from the tsconfig it found relative to the CALLER's cwd — the stage worked from the engine checkout (how the suites run it) and failed from anywhere else with "Cannot find module '@/bundle/build'", after the solve had completed. Every real consumer runs from its own repository, so bin/axiomcode was broken from any other directory. run-souffle.sh now passes --tsconfig "$PKG/tsconfig.json"; the bundle preflight runs the stage from a foreign working directory so the fault cannot return unseen. package-lock.json (root and parser/) leave the repository and are ignored. Fixes #470
swapnilpaliwal-sd
added
bug
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #470.
run-souffle.shlaunched the bundle stage astsx graph/bundle/cli.ts;cli.tsimports through the@/alias, which tsx resolves from the tsconfig it finds relative to the caller's cwd. So the stage worked from the engine checkout (the suites) and failed from anywhere else withCannot find module '@/bundle/build', after Soufflé had solved. Reproduced onmainfrom/tmpwith both the executor andbin/axiomcode(the one-command path is exactly the from-another-repo case).Fix:
tsx --tsconfig "$PKG/tsconfig.json". The bundle preflight (graph/test/tools/bundle-test.sh) now runs the stage from a foreign working directory, so the fault cannot come back unseen. Verified: executor andbin/axiomcodefrom/tmpboth producegraph.sqlite; the preflight passes.Also:
package-lock.json(root andparser/) removed from the repository and ignored.