changed: a declaration longer or gone in the base than in the graph's text keeps its own lines - #1846
Merged
swapnilpaliwal-sd merged 1 commit intoOct 2, 2026
Conversation
… text keeps its own lines - a span carried from a later graph text onto the base runs on over the lines only the base has while they are still inside it (braces open, or deeper indentation): statements a later text deleted were charged to the method below or dropped - a deleted field line the graph never held is named as that field, removed, not an anonymous 'inside <type>' - a range read with the graph at its newer side turns 'added' into 'removed', like 'removed' into 'added' Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
October 1, 2026 20:35
swapnilpaliwal-sd
deleted the
apps/java/changed-maps-hunks-to-wrong-declaration
branch
October 2, 2026 17:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the graph is built from a text other than the range's base (a later commit, or the newer side of the range),
changedmisplaced hunks:inside <type>. It is now named as that field, removed.addedwas not inverted, so a removed method or field readadded — new method. It is nowremoved, and the swapped "line(s) gone" note is labelledremoved.grown-file-read-against-its-basecase and two new Python checks, each with a control (an edit only in the method below). Both new checks failed before the fix.Checked: tests/run.py, all 5 languages, 1394/1394 checks; java suite 79 passed, 0 failed. changed_range, edit_stale_spans and hook_rebase fail on the same checks as the base branch.