Skip to content

MeasurementAnalyticsClient.AdjustUriBeforeRequest cuts strings with special chars #39

Open

Description

@xmedeko

Sent strings are malformed in the MeasurementAnalyticsClient.AdjustUriBeforeRequest method, when a string contains chars = or &.

E.g. sending

AutoMeasurement.Client.TrackEvent("My Action", "My Custom Category", "My Label id=345");

results in sending label="My Label id" only.

I've solved problem either by using UriFormat.UriEscaped, or fix GetQueryParameters method by q.Split(new char[] {'='}, 2). (Just one of this fix solved problem.)

Note: Such Uri construction, parsing and again construction is often source of problems. (My experience from several other applications.) Better to avoid it. Just construct the right Uri once and send it.

Activity

  1. damieng commented on Sep 2, 2015

    @damieng
    Contributor

    A heads up this project is no longer under active development. (it hasn't been touched in 7 months)

  2. xmedeko commented on Sep 2, 2015

    @xmedeko
    Author

    It's pity to leave such popular project - about 120 stars, 30 forks. May you write it to the README.md, that you no longer actively develop this project? What about trying to find another maintainer?

    If I send a pul request, will you merge it and release a new version?
    Thanks

  3. changed the title [-]MeasurementAnalyticsClient.AdjustUriBeforeRequest cut strings with contain equal char[/-] [+]MeasurementAnalyticsClient.AdjustUriBeforeRequest cuts strings with special chars[/+] on Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions