Repository navigation
Conversation
There were a few TrendingTask test leftovers in the test QCDB from last few months. While the root cause is unknown, hopefully the following changes improve the situation: - we create `cleanTestObjects` before storing the first object instead of after creating all of them - we catch exceptions in `cleanTestObjects` for better error reporting in case of a failed `truncate` and a crash due to an unhandled exception in the destructor. - we add additional REQUIRE checks before risking out-of-bound access, to avoid the test crashing and skipping the cleanup Hopefully it fixes QC-1365
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few TrendingTask test leftovers in the test QCDB from last few months. While the root cause is unknown, hopefully the following changes improve the situation:
cleanTestObjectsbefore storing the first object instead of after creating all of themcleanTestObjectsfor better error reporting in case of a failedtruncateand a crash due to an unhandled exception in the destructor.Hopefully it fixes QC-1365