Repository navigation
Conversation
|
O2 linter results: ❌ 0 errors, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new subgenerator ID specifically for hard process/signal events in JJ and GJ MCs, so that JJ/GJ events can be unambiguously identified relative to MB events.
From this definition of MCGenIdEncoding, the last 5 LSBs of the encoding are the subgenerator ID, and requesting it with
.getSubGeneratorId()returns 1 minus this value. So:True MB events from MB MC: encoding = 127 = 00000 0000 1111111
subGeneratorId= 0, so.getSubGeneratorIdreturns -1MB gap events in JJ and GJ MC: encoding = 2175 = 00001 0000 1111111
subGeneratorId= 1, so.getSubGeneratorIdreturns 0GJ and JJ sig events in JJ MC: encoding = 4223 = 00010 0000 1111111
subGeneratorId= 2, so.getSubGeneratorIdreturns 1