Skip to content

[PWGEM] MomentumSmearer: Change cast of type TH2F to TH2 - #18785

Merged
feisenhu merged 2 commits into
AliceO2Group:masterfrom
feisenhu:master
Nov 18, 2026
Merged

feisenhu merged 2 commits into
AliceO2Group:masterfrom
feisenhu:master

Conversation

@feisenhu

Copy link
Copy Markdown
Collaborator

After the changes of #18387 there is a mismatch between TH2F histograms and TH1D projections. This was fixed by #18735.
Furhtermore, there seems now a mismatch when looking for the type of histograms from the resolution files.
Thus I suggest to change the cast from TH2F to TH2, so it does not matter if the resolution is a TH2D or a TH2F histogram.

feisenhu and others added 2 commits November 16, 2026 15:14
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
[PWGEM] Accept generic 2D resolution histograms
Copilot AI balanced review requested due to automatic review settings November 17, 2026 08:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added the pwgem label Nov 17, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 20 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title [PWGEM] MomentumSmearer: Change cast of type TH2F to TH2 [PWGEM] MomentumSmearer: Change cast of type TH2F to TH2 Nov 17, 2026
@alibuild

alibuild commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 3e393d0 at 2026-11-18 00:49:

No log files found

Full log here.

@feisenhu
feisenhu enabled auto-merge (squash) November 18, 2026 10:50

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @feisenhu.

@feisenhu
feisenhu merged commit be13808 into AliceO2Group:master Nov 18, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants