Repository navigation
Conversation
This fixes the track-to-collision-association configuration used by the AnalysisQC. - usePVAssociation is an int in O2Physics since AliceO2Group/O2Physics#15929, but the config set it to "true". - DPL could not convert the value and ignored the whole configuration block of the task. - With "1" the configured timeMargin (500) and includeUnassigned (true) now take effect. AliceO2Group/O2Physics#15929
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the track-to-collision-association configuration used by the AnalysisQC.
usePVAssociation is an int since AliceO2Group/O2Physics#15929, but the config still set it to "true". DPL cannot convert the value and ignores the whole configuration block of the task, so HFDzeroQA ran with timeMargin 0 and includeUnassigned false instead of the configured 500 and true. The dumped dpl-config.json of an AnalysisQC run shows this.
With "1" the association mode stays the same and the configured timeMargin and includeUnassigned take effect. On a pp AO2D (run 536683) this changes the hf-track-index-skim-creator histograms by 2-6 % in entries. Please check that these settings are still the intended ones.