Skip to content

Make AnalysisQC analyses runnable on their own and allow AnalysisQC in anchored MC - #2552

Open
sawenzel wants to merge 3 commits into
AliceO2Group:masterfrom
sawenzel:analysisqc-split-deps
Open

sawenzel wants to merge 3 commits into
AliceO2Group:masterfrom
sawenzel:analysisqc-split-deps

Conversation

@sawenzel

@sawenzel sawenzel commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

This PR fixes AnalysisQC analyses that fail when run with --split-analyses and adds an
option to run the AnalysisQC in anchored MC.

Since #2149 the propagation service reads the TPC PID tables, but eight analysis chains
did not contain o2-analysis-pid-tpc-service. Run on their own, seven enabled analyses
aborted on missing O2pidtpcfull* trees. The merged AnalysisQC was not affected.

ALIEN_JDL_RUNANALYSISQC=1 makes anchorMC.sh include the AnalysisQC (without QCDB upload)
in the workflow targets. The 2-tag test template sets it, so release checks now fail when
the AnalysisQC fails.

The workflow tests now also run each analysis on its own (--split-analyses) on the AO2D
of the test workflows, so a missing dependency fails the test.

In summary:

  • all 12 enabled analyses produce AnalysisResults.root with --split-analyses (O2PDPSuite daily-20261116, pp run 536683 AO2D)
  • merged AnalysisQC output unchanged (RelVal before/after)
  • local anchored 2-tag job with the option passes and writes AnalysisResults.root
  • test/run_workflow_tests.sh passes with this PR; without the PID fix the new split step fails on the seven analyses

Assisted by Claude Code.

sawenzel and others added 2 commits November 17, 2026 21:03
This fixes AnalysisQC analyses that fail when run on their own with --split-analyses.

- The propagation service runs processRealDataWithPID and therefore reads the pidTPCFull tables.
- Eight chains contained the propagation service but no o2-analysis-pid-tpc-service, so the AOD reader aborted on missing O2pidtpcfull* trees.
- The merged AnalysisQC was not affected because other analyses bring the PID service in.
- o2-analysis-pid-tpc-service is now part of these chains.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This adds an option to run the AnalysisQC in anchored MC and enables it in the 2-tag test.

- ALIEN_JDL_RUNANALYSISQC=1 passes --include-analysis to the workflow creation and adds the analysis tasks to the targets.
- The QCDB upload tasks of the AnalysisQC are not targeted.
- The option is ignored with a message when O2Physics is not loaded.
- The 2-tag test template sets it, so release checks fail when the AnalysisQC fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sawenzel
sawenzel requested a review from jackal1-66 as a code owner November 17, 2026 20:11
@github-actions

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

This adds a split-mode AnalysisQC run to the workflow tests.

- The tests ran the AnalysisQC only in merged mode, where one analysis can provide the tables of another.
- The AO2D of the test workflow is now also processed with --split-analyses.
- An analysis that misses a task it needs now fails the test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant