Repository navigation
Conversation
This removes the sub-nanometre gaps and overlaps between the layers of the MCH slats and adds a unit test. - The slat layers were placed from float sums, so neighbouring faces overlapped or were up to 2e-8 cm apart. - TGeo navigation wrote empty MCH hits at these faces, and VecGeom navigation took zero-length steps in the gaps. - The constants and placement coordinates of Station345Geometry are double now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes sub-nanometre gaps and overlaps between the layers of the MCH slats (stations 3–5). The layers were stacked from
floatsums, so neighbouring faces overlapped or were up to 2e-8 cm apart.With TGeo navigation these faces produced empty MCH hits (zero length, zero energy loss), 8–10 % of all MCH hits in pp. With VecGeom navigation the gaps gave zero-length steps in the chamber air. Constants and placements of
Station345Geometryare nowdouble, and a unit test checks that the slat layers touch exactly (342 near-touching face pairs before).With TGeo, the empty hits drop from about 1000 to 88 per 6000 pp events, and kVecGeom/kTGeo MCH hits go from 0.905 ± 0.026 to 0.992 ± 0.026.
Assisted by Claude Code.