Repository navigation
Resolve internal issue 445: update dense reference vector implementation - #20
Merged
6 commits merged intoJun 1, 2022
Conversation
added 5 commits
May 31, 2022 16:26
Also, adapt reference matrix to vector signature change.
The interface offers Vector as a separate class, but behind the scenes, vector inherits from Matrix and makes use of all its existing mechanisms.
Also improve coding style of template arguments (aligning, ordering, etc)
ghost
requested a review
from hidanielesgit
May 31, 2022 14:28
hidanielesgit
suggested changes
Jun 1, 2022
| lambda_reference operator[]( const size_t i ) noexcept { | ||
| assert( i < _length() ); | ||
| //assert( getInitialized( *v ) ); | ||
| return this->access( this->amf.getStorageIndex( i, 1 ) ); |
| const lambda_reference operator[]( const size_t i ) const noexcept { | ||
| assert( i < _length() ); | ||
| //assert( getInitialized( *v ) ); | ||
| return this->access( this->amf.getStorageIndex( i, 1 ) ); |
ghost
requested a review
from hidanielesgit
June 1, 2022 08:09
hidanielesgit
approved these changes
Jun 1, 2022
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vector is implemented as a Nx1 Matrix behind the scenes and reuses existing mechanisms present in Matrix class.