Skip to content

Resolve internal issue 445: update dense reference vector implementation - #20

Merged
6 commits merged into
303-develop-reference_dense-backendfrom
445-update-dense-reference-vector-implementation
Jun 1, 2022
Merged

6 commits merged into
303-develop-reference_dense-backendfrom
445-update-dense-reference-vector-implementation

Conversation

@ghost

@ghost ghost commented May 31, 2022

Copy link
Copy Markdown

Vector is implemented as a Nx1 Matrix behind the scenes and reuses existing mechanisms present in Matrix class.

Vladimir Dimic added 5 commits May 31, 2022 16:26
Also, adapt reference matrix to vector signature change.
The interface offers Vector as a separate class,
but behind the scenes, vector inherits from Matrix
and makes use of all its existing mechanisms.
Also improve coding style of template arguments (aligning, ordering, etc)
@ghost
ghost requested a review from hidanielesgit May 31, 2022 14:28
@ghost ghost changed the title 445 update dense reference vector implementation Resolve internal issue 445: update dense reference vector implementation May 31, 2022
Comment thread include/alp/reference/vector.hpp Outdated
lambda_reference operator[]( const size_t i ) noexcept {
assert( i < _length() );
//assert( getInitialized( *v ) );
return this->access( this->amf.getStorageIndex( i, 1 ) );

ghost Jun 1, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should 1 -> 0?

ghost Jun 1, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Comment thread include/alp/reference/vector.hpp Outdated
const lambda_reference operator[]( const size_t i ) const noexcept {
assert( i < _length() );
//assert( getInitialized( *v ) );
return this->access( this->amf.getStorageIndex( i, 1 ) );

ghost Jun 1, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should 1 -> 0?

@ghost
ghost requested a review from hidanielesgit June 1, 2022 08:09
@ghost
ghost merged commit 17bc80c into 303-develop-reference_dense-backend Jun 1, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant