fix: mobile table overflow, branded 404, and complete Twitter card - #77
Open
TimeToBuildBob wants to merge 1 commit into
Open
TimeToBuildBob wants to merge 1 commit into
TimeToBuildBob wants to merge 1 commit into
Conversation
- Wide post tables (feature comparison, contributors) scroll inside themselves on phones instead of panning the whole page sideways. - Crypto donation addresses wrap instead of being clipped. - Add a Jekyll 404.html so missing pages get site nav instead of the generic GitHub Pages error. - twitter:title falls back to the site title (homepage rendered it empty) and the default twitter:image is absolute; X ignores relative card images. Co-Authored-By: Bob <bob@superuserlabs.org> Git-Session-Id: ff82
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes from a Playwright pass at 390×844 and 1280×800:
/contributors/table.dataframeat 645px) made the whole page pan sideways on a 390px viewport. On phones ($on-palm),.post-content tablenow getsdisplay: block; overflow-x: auto, so the table scrolls inside itself. Desktop rendering is unchanged. The Bitcoin/Ether addresses on/donate/are one unbreakable token and were clipped; they now wrap.404.html, soactivitywatch.net/does-not-existserved GitHub's generic "Site not found" page with no nav. This adds a Jekyll404.html(pagelayout) linking Home, Downloads, Blog, Docs and Forum. GitHub Pages still returns HTTP 404 for it.<meta name="twitter:title" content="">becausepage.titleis empty there, and the defaulttwitter:imagewas relative (/img/media/banners/banner-social.png), which X ignores. The title now falls back tosite.title, and the image is prefixed withsite.url, the same asog:imagealready is. Since the default image is the wide social banner, the default card issummary_large_image.Not built locally (no Jekyll toolchain on this host); the Pages workflow builds it.