diff --git a/lib/casclient/responses.rb b/lib/casclient/responses.rb index 099e00e5..f4044b76 100644 --- a/lib/casclient/responses.rb +++ b/lib/casclient/responses.rb @@ -190,8 +190,15 @@ def parse_http_response(http_response) if location =~ /ticket=([^&]+)/ @ticket = $~[1] end - - if not ((http_response.kind_of?(Net::HTTPSuccess) || http_response.kind_of?(Net::HTTPFound)) && @ticket.present?) + + # Legacy check. CAS Server used to return a 200 (Success) or a 302 (Found) on successful authentication. + # This behavior should be deprecated at some point in the future. + legacy_valid_ticket = (http_response.kind_of?(Net::HTTPSuccess) || http_response.kind_of?(Net::HTTPFound)) && @ticket.present? + + # If using rubycas-server 1.1.0+ + valid_ticket = http_response.kind_of?(Net::HTTPSeeOther) && @ticket.present? + + if !legacy_valid_ticket && !valid_ticket @failure = true # Try to extract the error message -- this only works with RubyCAS-Server. # For other servers we just return the entire response body (i.e. the whole error page).