From 5eb8efa38a75e8b28e3aaf483ac62b4f3f962248 Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Fri, 23 May 2025 14:16:22 -0700 Subject: [PATCH] Disable enableModuleArgumentNSNullConversionIOS by default Summary: This is causing some internal test failures for now, so disabling the behaviour to prevent further rollout. Changelog: [iOS] Disable fix for #51103 until more testing can be done. Differential Revision: D75320842 --- .../internal/featureflags/ReactNativeFeatureFlagsDefaults.kt | 4 ++-- .../react/featureflags/ReactNativeFeatureFlagsDefaults.h | 4 ++-- .../scripts/featureflags/ReactNativeFeatureFlags.config.js | 2 +- .../src/private/featureflags/ReactNativeFeatureFlags.js | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt index ac1ff11dfe10..9ecdf8b7c7d0 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<> + * @generated SignedSource<<07ea15d4fd3f3bc73c8f49cd24724caf>> */ /** @@ -71,7 +71,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi override fun enableMainQueueModulesOnIOS(): Boolean = false - override fun enableModuleArgumentNSNullConversionIOS(): Boolean = true + override fun enableModuleArgumentNSNullConversionIOS(): Boolean = false override fun enableNativeCSSParsing(): Boolean = false diff --git a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h index 9b6fcd9ffeda..58a4520dab37 100644 --- a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h +++ b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<> + * @generated SignedSource<<6692978a1497fa9e99d539511388c9fa>> */ /** @@ -124,7 +124,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider { } bool enableModuleArgumentNSNullConversionIOS() override { - return true; + return false; } bool enableNativeCSSParsing() override { diff --git a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js index 00eeb4034dcf..9e7249b0b9e0 100644 --- a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js +++ b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js @@ -300,7 +300,7 @@ const definitions: FeatureFlagDefinitions = { ossReleaseStage: 'none', }, enableModuleArgumentNSNullConversionIOS: { - defaultValue: true, + defaultValue: false, metadata: { description: 'Enable NSNull conversion when handling module arguments on iOS', diff --git a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js index d4ade2d60805..8096ad8c0565 100644 --- a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js +++ b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<> + * @generated SignedSource<<4d96a5f9132ea827faeb183fe8bbf095>> * @flow strict * @noformat */ @@ -281,7 +281,7 @@ export const enableMainQueueModulesOnIOS: Getter = createNativeFlagGett /** * Enable NSNull conversion when handling module arguments on iOS */ -export const enableModuleArgumentNSNullConversionIOS: Getter = createNativeFlagGetter('enableModuleArgumentNSNullConversionIOS', true); +export const enableModuleArgumentNSNullConversionIOS: Getter = createNativeFlagGetter('enableModuleArgumentNSNullConversionIOS', false); /** * Parse CSS strings using the Fabric CSS parser instead of ViewConfig processing */