From 9b94c707c78b705f758478e3ef9c35297e8a4a67 Mon Sep 17 00:00:00 2001 From: Ruben Vorderman Date: Mon, 6 Nov 2023 08:26:11 +0100 Subject: [PATCH 1/9] Install tox and use asan on arch installs --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 338a177c..6bcedf72 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -117,8 +117,9 @@ jobs: distro: none base_image: "--platform=linux/arm64 quay.io/pypa/manylinux2014_aarch64" run: |- - CFLAGS="-DNDEBUG -g0" python${{matrix.python_version}} -m pip install . pytest - python${{matrix.python_version}} -m pytest tests + pip install tox + tox -e asan + CFLAGS=-g0 -DNDEBUG tox # Test if the python-isal conda package can be build. Which is linked # dynamically to the conda isa-l package. From c600ee9a09fa925fdc4421046e3aa9dcd2c604a9 Mon Sep 17 00:00:00 2001 From: Ruben Vorderman Date: Mon, 6 Nov 2023 08:27:07 +0100 Subject: [PATCH 2/9] Disable arch prerequisites --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6bcedf72..25154a20 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -100,7 +100,7 @@ jobs: uses: codecov/codecov-action@v1 test-arch: - if: startsWith(github.ref, 'refs/tags') || github.ref == 'refs/heads/develop' || github.ref == 'refs/heads/main' +# if: startsWith(github.ref, 'refs/tags') || github.ref == 'refs/heads/develop' || github.ref == 'refs/heads/main' runs-on: "ubuntu-latest" strategy: matrix: From 9992dfd936041e6a67e4c121b59cb2632e343b90 Mon Sep 17 00:00:00 2001 From: Ruben Vorderman Date: Mon, 6 Nov 2023 08:31:02 +0100 Subject: [PATCH 3/9] Use appropriate python version --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 25154a20..d601f479 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -117,9 +117,9 @@ jobs: distro: none base_image: "--platform=linux/arm64 quay.io/pypa/manylinux2014_aarch64" run: |- - pip install tox - tox -e asan - CFLAGS=-g0 -DNDEBUG tox + python${{ matrix.python_version }} -m pip install tox + python${{ matrix.python_version }} -m tox -e asan + CFLAGS=-g0 -DNDEBUG python${{ matrix.python_version }} -m tox # Test if the python-isal conda package can be build. Which is linked # dynamically to the conda isa-l package. From 82202037f4d0fd684318e8ef868e5c2cc64a85af Mon Sep 17 00:00:00 2001 From: Ruben Vorderman Date: Mon, 6 Nov 2023 09:00:19 +0100 Subject: [PATCH 4/9] Increase verbosity --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d601f479..f3f15c4f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -118,7 +118,7 @@ jobs: base_image: "--platform=linux/arm64 quay.io/pypa/manylinux2014_aarch64" run: |- python${{ matrix.python_version }} -m pip install tox - python${{ matrix.python_version }} -m tox -e asan + python${{ matrix.python_version }} -m tox -vv -e asan CFLAGS=-g0 -DNDEBUG python${{ matrix.python_version }} -m tox # Test if the python-isal conda package can be build. Which is linked From b7fe4721dd54620e18c5907b8b3779e4ae81a23f Mon Sep 17 00:00:00 2001 From: Ruben Vorderman Date: Mon, 6 Nov 2023 10:56:11 +0100 Subject: [PATCH 5/9] Don't run commands via tox --- .github/workflows/ci.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f3f15c4f..f19f3e67 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -117,9 +117,10 @@ jobs: distro: none base_image: "--platform=linux/arm64 quay.io/pypa/manylinux2014_aarch64" run: |- - python${{ matrix.python_version }} -m pip install tox - python${{ matrix.python_version }} -m tox -vv -e asan - CFLAGS=-g0 -DNDEBUG python${{ matrix.python_version }} -m tox + CFLAGS="-lasan -fsanitize=address -fno-omit-frame-pointer" python${{ matrix.python_version }} -m pip install . + PYTHONDEVMODE=1 PYTHONMALLOC=malloc LD_PRELOAD=$(gcc -print-file-name=libasan.so) pytest tests + CFLAGS="-g0 -DNDEBUG" python${{ matrix.python_version }} -m pip install . + pytest tests # Test if the python-isal conda package can be build. Which is linked # dynamically to the conda isa-l package. From c4cbd703c3d66feeabce24e20d5ebd6a1eae2310 Mon Sep 17 00:00:00 2001 From: Ruben Vorderman Date: Mon, 6 Nov 2023 11:16:32 +0100 Subject: [PATCH 6/9] Install libasan --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f19f3e67..0255e7ff 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -117,6 +117,7 @@ jobs: distro: none base_image: "--platform=linux/arm64 quay.io/pypa/manylinux2014_aarch64" run: |- + yum install -y libasan6.aarch64 CFLAGS="-lasan -fsanitize=address -fno-omit-frame-pointer" python${{ matrix.python_version }} -m pip install . PYTHONDEVMODE=1 PYTHONMALLOC=malloc LD_PRELOAD=$(gcc -print-file-name=libasan.so) pytest tests CFLAGS="-g0 -DNDEBUG" python${{ matrix.python_version }} -m pip install . From bd813a677e799858bbfe85111acb7cd5a98cc75f Mon Sep 17 00:00:00 2001 From: Ruben Vorderman Date: Mon, 6 Nov 2023 11:21:07 +0100 Subject: [PATCH 7/9] Install devtoolset package --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0255e7ff..aa925a63 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -117,7 +117,7 @@ jobs: distro: none base_image: "--platform=linux/arm64 quay.io/pypa/manylinux2014_aarch64" run: |- - yum install -y libasan6.aarch64 + yum install -y devtoolset-10-libasan-devel.aarch64 CFLAGS="-lasan -fsanitize=address -fno-omit-frame-pointer" python${{ matrix.python_version }} -m pip install . PYTHONDEVMODE=1 PYTHONMALLOC=malloc LD_PRELOAD=$(gcc -print-file-name=libasan.so) pytest tests CFLAGS="-g0 -DNDEBUG" python${{ matrix.python_version }} -m pip install . From c999994dad77397bdc1f9a78af46b12cfbb75fec Mon Sep 17 00:00:00 2001 From: Ruben Vorderman Date: Mon, 6 Nov 2023 11:27:47 +0100 Subject: [PATCH 8/9] Use python version to run pytest --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index aa925a63..7b96208c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -119,9 +119,9 @@ jobs: run: |- yum install -y devtoolset-10-libasan-devel.aarch64 CFLAGS="-lasan -fsanitize=address -fno-omit-frame-pointer" python${{ matrix.python_version }} -m pip install . - PYTHONDEVMODE=1 PYTHONMALLOC=malloc LD_PRELOAD=$(gcc -print-file-name=libasan.so) pytest tests + PYTHONDEVMODE=1 PYTHONMALLOC=malloc LD_PRELOAD=$(gcc -print-file-name=libasan.so) python${{ matrix.python_version }} -m pytest tests CFLAGS="-g0 -DNDEBUG" python${{ matrix.python_version }} -m pip install . - pytest tests + python${{ matrix.python_version }} -m pytest tests # Test if the python-isal conda package can be build. Which is linked # dynamically to the conda isa-l package. From 86d4c35b9707d61bc62507200f3d68a92e2fa6b8 Mon Sep 17 00:00:00 2001 From: Ruben Vorderman Date: Mon, 6 Nov 2023 11:28:45 +0100 Subject: [PATCH 9/9] Also intall pytest --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7b96208c..1bbe2c9a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -118,10 +118,12 @@ jobs: base_image: "--platform=linux/arm64 quay.io/pypa/manylinux2014_aarch64" run: |- yum install -y devtoolset-10-libasan-devel.aarch64 - CFLAGS="-lasan -fsanitize=address -fno-omit-frame-pointer" python${{ matrix.python_version }} -m pip install . - PYTHONDEVMODE=1 PYTHONMALLOC=malloc LD_PRELOAD=$(gcc -print-file-name=libasan.so) python${{ matrix.python_version }} -m pytest tests + python${{ matrix.python_version }} -m pip install pytest CFLAGS="-g0 -DNDEBUG" python${{ matrix.python_version }} -m pip install . python${{ matrix.python_version }} -m pytest tests + CFLAGS="-lasan -fsanitize=address -fno-omit-frame-pointer" python${{ matrix.python_version }} -m pip install . + PYTHONDEVMODE=1 PYTHONMALLOC=malloc LD_PRELOAD=$(gcc -print-file-name=libasan.so) python${{ matrix.python_version }} -m pytest tests + # Test if the python-isal conda package can be build. Which is linked # dynamically to the conda isa-l package.