Repository navigation
Conversation
Problem: pointer "key" is checked for null at var.c:1016, but is dereferenced right before the check. Solution: additional check for "key" before dereferencing. Signed-off-by: David Meliksetyan <d.meliksetyan@fobos-nt.ru> Signed-off-by: Georgij Tsarin <cristarm@altlinux.org>
Member
|
Hi @M0T1VaTeD ! would it be possible to provide a test that would make php crash without your fix ? Thanks. |
Member
|
I think this is more of a defensive optimization rather than an actual bug fix so its not necessaryly testable? So it is targeting master wdyt @devnexen |
Member
I knew it was not testable, my point being if there is no bug there is no fix to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: pointer "key" is checked for null at var.c:1016, but is dereferenced right before the check.
Solution: additional check for "key" before dereferencing.