Skip to content

Docs: @propType and @hide annotations do not function #2332

Closed

Description

@dlabrecq

When I add @deprecated to a component prop, I can see it output in the example docs. However, I don't see a similar result with the @propType and @hide functionality added via #1671.

I'm expecting to see a different property type, for Chart props below, which is shown by the area chart example.

export interface ChartProps extends VictoryChartProps {
  /**
   * The animate prop specifies props for VictoryAnimation to use.
   * The animate prop should also be used to specify enter and exit
   * transition configurations with the `onExit` and `onEnter` namespaces respectively.
   *
   * @example {duration: 500, onExit: () => {}, onEnter: {duration: 500, before: () => ({y: 0})})}
   *
   * @propType boolean || object <------------
   */
  animate?: boolean | AnimatePropTypeInterface;

Is there a trick to get this working locally? I can see @deprecated when I rebuild the docs, but @propType and @hide do not appear to do anything.

Screen Shot 2020-12-28 at 12 40 14 PM

Activity

  1. dlabrecq commented on Dec 28, 2020

    @dlabrecq
    MemberAuthor
  2. changed the title [-]Docs: @propType and @hide do not appear to function[/-] [+]Docs: @propType and @hide annotation do not function[/+] on Dec 28, 2020
  3. changed the title [-]Docs: @propType and @hide annotation do not function[/-] [+]Docs: @propType and @hide annotations do not function[/+] on Dec 28, 2020
  4. redallen commented on Jan 4, 2021

    @redallen
    Contributor

    The file responsible for implementing these did have @propType removed when upgrading the site. We can add that back and see why @hide isn't working like you expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions