From 0abffbe6fc0b743b3f19d77275291a6fabff1b8d Mon Sep 17 00:00:00 2001 From: Ulises Gascon Date: Mon, 20 Feb 2023 19:49:50 +0100 Subject: [PATCH 1/4] doc: add meeting notes 2023-02-20 (#58) Signed-off-by: Ulises Gascon --------- Co-authored-by: Yagiz Nizipli --- meetings/2023-02-20.md | 53 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 meetings/2023-02-20.md diff --git a/meetings/2023-02-20.md b/meetings/2023-02-20.md new file mode 100644 index 0000000..fae613f --- /dev/null +++ b/meetings/2023-02-20.md @@ -0,0 +1,53 @@ +# Node.js Performance Team Meeting 2023-02-20 + +## Links + +* **Recording**: https://www.youtube.com/watch?v=KLsxXja1fYs +* **GitHub Issue**: https://github.com/nodejs/performance/issues/58 + +## Present + +* Performance team: @nodejs/performance +* Yagiz Nizipli: @anonrig +* Ulises Gascon: @ulisesGascon +* Santiago Gimeno: @santigimeno +* Juan Arboleda: @soyjuanarbol + + +## Agenda + +## Announcements + +- The new URL parser will be released this week! +- It was a productive week for all of us! Other improvements had been made by the group members (Ruben, Joyee and multiple other collaborators) based on separated issues +- Santiago is planning to do a new PR for event creation this week + +*Extracted from **performance-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. + +### nodejs/performance + +* getLibuvNow is slow [#49](https://github.com/nodejs/performance/issues/49) + - Seems that there is a fix for it, related to timers (https://github.com/nodejs/node/pull/46579) with v8 fastApi. (Thanks to joyee!) +It will be removed from the agenda +* AbortSignal pattern is slow [#44](https://github.com/nodejs/performance/issues/44) + - Ruben created a PR to reduce error creation duration by 86-166% (Amazing work!) + - There are several issues with AbortSignal Pattern + - Emitting events is slow (Santiago will open a PR to improve this) + - Adding and removing event listeners in event Targets. This is actually the main issue. New issue: https://github.com/nodejs/performance/issues/60 + - We have specific perf benchmarks for events (adding and removing) in https://github.com/nodejs/node/blob/main/benchmark/events/eventtarget.js, seems like we should potentially update them for EventTarget addition/removal. +* Module resolution [#39](https://github.com/nodejs/performance/issues/39) + - Yagiz did some research and a PR related to it (https://github.com/nodejs/node/pull/46652) - Not yet merged. We should add a caching layer once is merged + - There is a pending PR for changing off threading loaders. Until it gets merged, Yagiz’s pull request will be on hold to avoid git conflicts. +* WHATWG Streams [#9](https://github.com/nodejs/performance/issues/9) + - There is an option to improve this by moving the core logic to C++, similar to the work done by Deno and Bun, but requires extensive work. For the time being, we can close this issue. + - This item will be removed from the agenda + +## Q&A, Other +- Yagiz opened several PRs related to URL parsing and he discovered a happy path that has a more performing approach. There was a discussion around it with Daniel as this implementation may have a more complex implementation as hidden cost. It is an early stage yet to build a consensus. + +## Upcoming Meetings + +* **Node.js Foundation Calendar**: https://nodejs.org/calendar + +Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. + From 88fa5d717fa011508176b4bbd3bc8690d20fa1c0 Mon Sep 17 00:00:00 2001 From: Ulises Gascon Date: Tue, 21 Feb 2023 10:50:12 +0100 Subject: [PATCH 2/4] docs: update participants --- meetings/2023-02-20.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meetings/2023-02-20.md b/meetings/2023-02-20.md index fae613f..71e7b67 100644 --- a/meetings/2023-02-20.md +++ b/meetings/2023-02-20.md @@ -12,7 +12,8 @@ * Ulises Gascon: @ulisesGascon * Santiago Gimeno: @santigimeno * Juan Arboleda: @soyjuanarbol - +* Robert Nagy: @ronag +* Ruben Bridgewater: @BridgeAR ## Agenda From 6b8c8af0c40e1e00254d026dcbf00a67c01f5ca4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulises=20Gasc=C3=B3n?= Date: Tue, 21 Feb 2023 10:50:59 +0100 Subject: [PATCH 3/4] Update meetings/2023-02-20.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Tobias Nießen --- meetings/2023-02-20.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2023-02-20.md b/meetings/2023-02-20.md index 71e7b67..df46768 100644 --- a/meetings/2023-02-20.md +++ b/meetings/2023-02-20.md @@ -19,7 +19,7 @@ ## Announcements -- The new URL parser will be released this week! +- The new URL parser will be released this week! - It was a productive week for all of us! Other improvements had been made by the group members (Ruben, Joyee and multiple other collaborators) based on separated issues - Santiago is planning to do a new PR for event creation this week From d6d7d1096c9b5f0d4b2351662dac3d4e1b012b04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulises=20Gasc=C3=B3n?= Date: Tue, 21 Feb 2023 10:51:04 +0100 Subject: [PATCH 4/4] Update meetings/2023-02-20.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Tobias Nießen --- meetings/2023-02-20.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2023-02-20.md b/meetings/2023-02-20.md index df46768..b6ed2c1 100644 --- a/meetings/2023-02-20.md +++ b/meetings/2023-02-20.md @@ -29,7 +29,7 @@ * getLibuvNow is slow [#49](https://github.com/nodejs/performance/issues/49) - Seems that there is a fix for it, related to timers (https://github.com/nodejs/node/pull/46579) with v8 fastApi. (Thanks to joyee!) -It will be removed from the agenda + It will be removed from the agenda * AbortSignal pattern is slow [#44](https://github.com/nodejs/performance/issues/44) - Ruben created a PR to reduce error creation duration by 86-166% (Amazing work!) - There are several issues with AbortSignal Pattern