From f3b8e1b78378ca4349222b476cc49d88a11883eb Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Wed, 1 Apr 2020 15:37:11 -0700 Subject: [PATCH] deps: revert whitespace changes on V8 While landing some of the V8 upgrades on the v12 branch, something went wrong and git made unecessary (and incorrect) whitespace changes to test fixtures, which broke V8 tests. This was likely caused by the use of `git node land` or a simiar tool. Revert those changes to fix our tests. Since this only reverts unwanted changes on deps/v8, and it only affects tests, don't bump v8_embedder_string. --- .../bytecode_expectations/PrivateAccessorAccess.golden | 3 ++- .../PrivateAccessorDeclaration.golden | 3 ++- .../bytecode_expectations/PrivateMethodAccess.golden | 7 ++++--- .../bytecode_expectations/PrivateMethodDeclaration.golden | 1 + 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateAccessorAccess.golden b/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateAccessorAccess.golden index 37a5c0777a80..6fc00999a596 100644 --- a/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateAccessorAccess.golden +++ b/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateAccessorAccess.golden @@ -12,7 +12,7 @@ snippet: " class A { get #a() { return 1; } set #a(val) { } - + constructor() { this.#a++; this.#a = 1; @@ -189,3 +189,4 @@ constant pool: [ ] handlers: [ ] + diff --git a/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateAccessorDeclaration.golden b/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateAccessorDeclaration.golden index 4a21fd3d4bb3..aceee552b5d5 100644 --- a/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateAccessorDeclaration.golden +++ b/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateAccessorDeclaration.golden @@ -165,7 +165,7 @@ snippet: " get #d() { return 1; } set #d(val) { } } - + class E extends D { get #e() { return 2; } set #e(val) { } @@ -395,3 +395,4 @@ constant pool: [ ] handlers: [ ] + diff --git a/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateMethodAccess.golden b/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateMethodAccess.golden index ff17fcaceae4..d41b34218798 100644 --- a/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateMethodAccess.golden +++ b/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateMethodAccess.golden @@ -13,7 +13,7 @@ snippet: " #a() { return 1; } constructor() { return this.#a(); } } - + var test = A; new A; " @@ -44,7 +44,7 @@ snippet: " #b() { return 1; } constructor() { this.#b = 1; } } - + var test = B; new test; " @@ -76,7 +76,7 @@ snippet: " #c() { return 1; } constructor() { this.#c++; } } - + var test = C; new test; " @@ -101,3 +101,4 @@ constant pool: [ ] handlers: [ ] + diff --git a/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateMethodDeclaration.golden b/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateMethodDeclaration.golden index b9fd82000988..d1aab34fda79 100644 --- a/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateMethodDeclaration.golden +++ b/deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateMethodDeclaration.golden @@ -195,3 +195,4 @@ constant pool: [ ] handlers: [ ] +