From 626c1e536cba3f83b1d949de2a99cdf101d1ba9e Mon Sep 17 00:00:00 2001 From: David Kutugata Date: Tue, 29 Oct 2019 16:48:56 -0700 Subject: [PATCH 1/3] removed extra space at the left of the native editor --- src/datascience-ui/native-editor/nativeEditor.less | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/datascience-ui/native-editor/nativeEditor.less b/src/datascience-ui/native-editor/nativeEditor.less index 23b669d21077..524618cf3675 100644 --- a/src/datascience-ui/native-editor/nativeEditor.less +++ b/src/datascience-ui/native-editor/nativeEditor.less @@ -28,7 +28,7 @@ margin: 1px 2px; border-color: transparent; border-style: solid; - border-width: 2px 2px 0px 20px; + border-width: 2px 2px 0px 0px; position: relative; min-height: 55px; } @@ -36,13 +36,13 @@ .cell-wrapper-focused { border-color: transparent; border-style: solid; - border-width: 2px 2px 0px 20px; + border-width: 2px 2px 0px 0px; } .cell-wrapper-selected { border-color: transparent; border-style: solid; - border-width: 2px 2px 0px 20px; + border-width: 2px 2px 0px 0px; } .cell-menu-bar-outer { From 43879da57d8855feb09254320945ce4c3ace2493 Mon Sep 17 00:00:00 2001 From: David Kutugata Date: Wed, 30 Oct 2019 09:59:12 -0700 Subject: [PATCH 2/3] changed the border to margin --- src/datascience-ui/native-editor/nativeEditor.less | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/datascience-ui/native-editor/nativeEditor.less b/src/datascience-ui/native-editor/nativeEditor.less index 524618cf3675..af4cd3899bd3 100644 --- a/src/datascience-ui/native-editor/nativeEditor.less +++ b/src/datascience-ui/native-editor/nativeEditor.less @@ -25,24 +25,17 @@ } .cell-wrapper { - margin: 1px 2px; - border-color: transparent; - border-style: solid; - border-width: 2px 2px 0px 0px; + margin: 2px 2px 0px 0px; position: relative; min-height: 55px; } .cell-wrapper-focused { - border-color: transparent; - border-style: solid; - border-width: 2px 2px 0px 0px; + margin: 2px 2px 0px 0px; } .cell-wrapper-selected { - border-color: transparent; - border-style: solid; - border-width: 2px 2px 0px 0px; + margin: 2px 2px 0px 0px; } .cell-menu-bar-outer { From aa8faf7c64f02fe0b956839408a8084c0f36bd00 Mon Sep 17 00:00:00 2001 From: David Kutugata Date: Wed, 30 Oct 2019 10:58:35 -0700 Subject: [PATCH 3/3] changed python version to match the one in azure --- build/ci/templates/globals.yml | 2 +- build/ci/templates/jobs/uitest.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build/ci/templates/globals.yml b/build/ci/templates/globals.yml index b12fbcc4909b..0faae1292437 100644 --- a/build/ci/templates/globals.yml +++ b/build/ci/templates/globals.yml @@ -1,5 +1,5 @@ variables: - PythonVersion: '3.7.4' # Always use latest version. + PythonVersion: '3.7.5' # Always use latest version. NodeVersion: '10.11.0' # Check version of node used in VS Code. NpmVersion: '6.10.3' MOCHA_FILE: '$(Build.ArtifactStagingDirectory)/test-junit.xml' # All test files will write their JUnit xml output to this file, clobbering the last time it was written. diff --git a/build/ci/templates/jobs/uitest.yml b/build/ci/templates/jobs/uitest.yml index 1d03bddcfafb..d6fd40ee2fe5 100644 --- a/build/ci/templates/jobs/uitest.yml +++ b/build/ci/templates/jobs/uitest.yml @@ -95,7 +95,7 @@ parameters: # All scenarios tagged with `@noNeedToTestInAllPython`, will run in the latest version of Python. # When using other versions of Python, ignore `@noNeedToTestInAllPython`. { - "version": "3.7.4", + "version": "3.7.5", "displayName": "37", "excludeTags": "not @python3.6 and not @python3.5 and not @python2" },