From 803348704a1d8e0001db42a042f29278f8dbb3f8 Mon Sep 17 00:00:00 2001 From: Piet van Dongen Date: Thu, 2 Apr 2015 21:26:30 +0200 Subject: [PATCH] Added triangle exercise (see #3) --- config.json | 3 +- triangle/build.gradle | 11 ++ triangle/example.java | 53 +++++++++ triangle/src/main/java/.keep | 0 triangle/src/main/java/Triangle.java | 2 + triangle/src/main/java/TriangleException.java | 5 + triangle/src/main/java/TriangleKind.java | 5 + triangle/src/test/java/TriangleTest.java | 101 ++++++++++++++++++ 8 files changed, 179 insertions(+), 1 deletion(-) create mode 100644 triangle/build.gradle create mode 100644 triangle/example.java create mode 100644 triangle/src/main/java/.keep create mode 100644 triangle/src/main/java/Triangle.java create mode 100644 triangle/src/main/java/TriangleException.java create mode 100644 triangle/src/main/java/TriangleKind.java create mode 100644 triangle/src/test/java/TriangleTest.java diff --git a/config.json b/config.json index 8c0e69761..51e28b8ad 100644 --- a/config.json +++ b/config.json @@ -15,7 +15,8 @@ "phone-number", "grade-school", "space-age", - "gigasecond" + "gigasecond", + "triangle" ], "deprecated": [ ], diff --git a/triangle/build.gradle b/triangle/build.gradle new file mode 100644 index 000000000..9af8b0b86 --- /dev/null +++ b/triangle/build.gradle @@ -0,0 +1,11 @@ +apply plugin: "java" +apply plugin: "eclipse" +apply plugin: "idea" + +repositories { + mavenCentral() +} + +dependencies { + testCompile "junit:junit:4.10" +} diff --git a/triangle/example.java b/triangle/example.java new file mode 100644 index 000000000..b65c42c17 --- /dev/null +++ b/triangle/example.java @@ -0,0 +1,53 @@ +public class Triangle { + + private double side1; + private double side2; + private double side3; + + public Triangle(double side1, double side2, double side3) throws TriangleException { + this.side1 = side1; + this.side2 = side2; + this.side3 = side3; + + if (allSidesAreZero() || hasImpossibleSides() || violatesTriangleInequality()) { + throw new TriangleException(); + } + } + + public TriangleKind getKind() { + int uniqueSides = getNumberOfUniqueSides(); + + if (uniqueSides == 1) { + return TriangleKind.EQUILATERAL; + } + + if (uniqueSides == 2) { + return TriangleKind.ISOSCELES; + } + + return TriangleKind.SCALENE; + } + + private boolean allSidesAreZero() { + return side1 == 0 && side2 == 0 && side3 == 0; + } + + private boolean hasImpossibleSides() { + return side1 < 0 || side2 < 0 || side3 < 0; + } + + private boolean violatesTriangleInequality() { + return side1 + side2 <= side3 || side1 + side3 <= side2 || side2 + side3 <= side1; + } + + + public int getNumberOfUniqueSides() { + Set sides = new HashSet<>(); + + sides.add(side1); + sides.add(side2); + sides.add(side3); + + return sides.size(); + } +} diff --git a/triangle/src/main/java/.keep b/triangle/src/main/java/.keep new file mode 100644 index 000000000..e69de29bb diff --git a/triangle/src/main/java/Triangle.java b/triangle/src/main/java/Triangle.java new file mode 100644 index 000000000..2bf010d59 --- /dev/null +++ b/triangle/src/main/java/Triangle.java @@ -0,0 +1,2 @@ +public class Triangle { +} diff --git a/triangle/src/main/java/TriangleException.java b/triangle/src/main/java/TriangleException.java new file mode 100644 index 000000000..3b1071e94 --- /dev/null +++ b/triangle/src/main/java/TriangleException.java @@ -0,0 +1,5 @@ +public class TriangleException extends Exception { + + public TriangleException() { + } +} diff --git a/triangle/src/main/java/TriangleKind.java b/triangle/src/main/java/TriangleKind.java new file mode 100644 index 000000000..5dbf64b90 --- /dev/null +++ b/triangle/src/main/java/TriangleKind.java @@ -0,0 +1,5 @@ +public enum TriangleKind { + EQUILATERAL, + ISOSCELES, + SCALENE +} diff --git a/triangle/src/test/java/TriangleTest.java b/triangle/src/test/java/TriangleTest.java new file mode 100644 index 000000000..2bee5d306 --- /dev/null +++ b/triangle/src/test/java/TriangleTest.java @@ -0,0 +1,101 @@ +import org.junit.Test; + +import static org.junit.Assert.assertEquals; + +public class TriangleTest { + + @Test + public void equilateralTriangleHaveEqualSides() throws Exception { + Triangle triangle = new Triangle(2, 2, 2); + + assertEquals(triangle.getKind(), TriangleKind.EQUILATERAL); + } + + @Test + public void largerEquilateralTrianglesAlsoHaveEqualSides() throws Exception { + Triangle triangle = new Triangle(10, 10, 10); + + assertEquals(triangle.getKind(), TriangleKind.EQUILATERAL); + } + + @Test + public void isoscelesTrianglesHaveLastTwoSidesEqual() throws Exception { + Triangle triangle = new Triangle(3, 4, 4); + + assertEquals(triangle.getKind(), TriangleKind.ISOSCELES); + } + + @Test + public void isoscelesTrianglesHaveFirstAndLastSidesEqual() throws Exception { + Triangle triangle = new Triangle(4, 3, 4); + + assertEquals(triangle.getKind(), TriangleKind.ISOSCELES); + } + + @Test + public void isoscelesTrianglesHaveTwoFirstSidesEqual() throws Exception { + Triangle triangle = new Triangle(4, 4, 3); + + assertEquals(triangle.getKind(), TriangleKind.ISOSCELES); + } + + @Test + public void isoscelesTrianglesHaveInFactExactlyTwoSidesEqual() throws Exception { + Triangle triangle = new Triangle(10, 10, 2); + + assertEquals(triangle.getKind(), TriangleKind.ISOSCELES); + } + + @Test + public void scaleneTrianglesHaveNoEqualSides() throws Exception { + Triangle triangle = new Triangle(3, 4, 5); + + assertEquals(triangle.getKind(), TriangleKind.SCALENE); + } + + @Test + public void scaleneTrianglesHaveNoEqualSidesAtLargerScaleEither() throws Exception { + Triangle triangle = new Triangle(10, 11, 12); + + assertEquals(triangle.getKind(), TriangleKind.SCALENE); + } + + @Test + public void scaleneTrianglesHaveNoEqualSidesInDescendingOrderEither() throws Exception { + Triangle triangle = new Triangle(5, 4, 2); + + assertEquals(triangle.getKind(), TriangleKind.SCALENE); + } + + @Test + public void verySmallTrianglesAreLegal() throws Exception { + Triangle triangle = new Triangle(0.4, 0.6, 0.3); + + assertEquals(triangle.getKind(), TriangleKind.SCALENE); + } + + @Test(expected = TriangleException.class) + public void trianglesWithNoSizeAreIllegal() throws Exception { + new Triangle(0, 0, 0); + } + + @Test(expected = TriangleException.class) + public void trianglesWithNegativeSidesAreIllegal() throws Exception { + new Triangle(3, 4, -5); + } + + @Test(expected = TriangleException.class) + public void trianglesViolatingTriangleInequalityAreIllegal() throws Exception { + new Triangle(1, 1, 3); + } + + @Test(expected = TriangleException.class) + public void trianglesViolatingTriangleInequalityAreIllegal2() throws Exception { + new Triangle(2, 4, 2); + } + + @Test(expected = TriangleException.class) + public void trianglesViolatingTriangleInequalityAreIllegal3() throws Exception { + new Triangle(7, 3, 2); + } +}