From ad039e519451fc71ddcb7ff37ac4d29078c8bebd Mon Sep 17 00:00:00 2001 From: HTHou Date: Thu, 13 Jun 2024 15:53:08 +0800 Subject: [PATCH 1/2] Optimize the log printing when multiple error occur --- .../java/org/apache/iotdb/rpc/RpcUtils.java | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java b/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java index 9b29f052f28b2..fc4d062e2087c 100644 --- a/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java +++ b/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java @@ -146,18 +146,20 @@ public static TSStatus getStatus(TSStatusCode tsStatusCode) { public static TSStatus getStatus(List statusList) { TSStatus status = new TSStatus(TSStatusCode.MULTIPLE_ERROR.getStatusCode()); status.setSubStatus(statusList); - StringBuilder errMsg = new StringBuilder().append("Multiple error occur, messages: "); - Set msgSet = new HashSet<>(); - for (TSStatus subStatus : statusList) { - if (subStatus.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode() - && subStatus.getCode() != TSStatusCode.REDIRECTION_RECOMMEND.getStatusCode()) { - if (!msgSet.contains(status.getMessage())) { - errMsg.append(status.getMessage()).append("; "); - msgSet.add(status.getMessage()); + if (LOGGER.isDebugEnabled()) { + StringBuilder errMsg = new StringBuilder().append("Multiple error occur, messages: "); + Set msgSet = new HashSet<>(); + for (TSStatus subStatus : statusList) { + if (subStatus.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode() + && subStatus.getCode() != TSStatusCode.REDIRECTION_RECOMMEND.getStatusCode()) { + if (!msgSet.contains(status)) { + errMsg.append(status).append("; "); + msgSet.add(status); + } } } + LOGGER.debug(errMsg.toString()); } - LOGGER.warn(errMsg.toString()); return status; } From db3d4c8a8d5a47bfe1ae3525cc1832355c0853a5 Mon Sep 17 00:00:00 2001 From: HTHou Date: Thu, 13 Jun 2024 16:28:05 +0800 Subject: [PATCH 2/2] Optimize the log printing when multiple error occur --- .../src/main/java/org/apache/iotdb/rpc/RpcUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java b/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java index fc4d062e2087c..e48054abb1974 100644 --- a/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java +++ b/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java @@ -158,7 +158,7 @@ public static TSStatus getStatus(List statusList) { } } } - LOGGER.debug(errMsg.toString()); + LOGGER.debug(errMsg.toString(), new Exception(errMsg.toString())); } return status; }