Skip to content

feat(policy): show effective transport scope in rule review - #5815

Open
alangou wants to merge 2 commits into
ai-openshell:mainfrom
alangou:feat/show-transport-rule-scope/alangou
Open

alangou wants to merge 2 commits into
ai-openshell:mainfrom
alangou:feat/show-transport-rule-scope/alangou

Conversation

@alangou

@alangou alangou commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Why

Show operators whether a proposed endpoint limits HTTP methods and paths before they approve it.

What changed

openshell rule get identifies transport-only grants with no HTTP method/path filter. The terminal review shows the same explanation in the endpoint detail and keeps the compact list labels. Both the omitted protocol and explicit tcp forms are covered. Authored HTTP rules that have no effect on a transport grant are omitted from that grant's review.

Verification

  • Exercised a pending rule on a local mTLS gateway and compared the base and patched CLI output on the same proposal.
  • The alternate destination rejected connections before approval. After manual approval it accepted a POST. The original endpoint still accepted its allowed GET and denied a POST and an out-of-scope path.
  • Tested CLI formatting for transport, read-only REST, and explicit allow/deny rules. Rendered the approval detail at 80 columns with transport and REST endpoints.

Signed-off-by: Adrien Langou <alangou@nvidia.com>
Signed-off-by: Adrien Langou <alangou@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 20, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 20, 2026
@alangou
alangou marked this pull request as ready for review November 20, 2026 13:59
@alangou

alangou commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 0e80b65

@alangou alangou added the test:e2e Requires end-to-end coverage label Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:accepted A maintainer decided OpenShell should pursue this issue test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant