Skip to content

refactor(drivers): stop passing the telemetry toggle into sandboxes - #5814

Open
SDAChess wants to merge 1 commit into
mainfrom
refactor/4554-drop-sandbox-telemetry-env/SDAChess
Open

SDAChess wants to merge 1 commit into
mainfrom
refactor/4554-drop-sandbox-telemetry-env/SDAChess

Conversation

@SDAChess

Copy link
Copy Markdown
Contributor

Summary

The Docker, Kubernetes, Podman and VM drivers copied the gateway's OPENSHELL_TELEMETRY_ENABLED value into every sandbox environment, but nothing in the sandbox read it. This drops the injection. It is the first of a short stack that removes the NVIDIA usage telemetry ahead of the move to ai-openshell/openshell.

Related Issue

Refs #4554

Changes

  • Remove sandbox_env::TELEMETRY_ENABLED and openshell_core::telemetry::enabled_env_value().
  • Stop injecting the variable in the Docker (create and image update), Kubernetes, Podman and VM drivers. Docker image updates now carry over only the log level.
  • Delete the tests that pinned the propagation, the ENV_LOCK statics that only served them, and the temp-env dev-dependency in the Kubernetes and Podman drivers.

Release Notes

Testing

  • Checks appropriate to the affected code and behavior pass: cargo clippy -D warnings, cargo fmt, and cargo test for core and the Docker, Kubernetes, Podman and VM drivers. Only the VM image_preparation tests that hardcode /bin/sleep//bin/dd fail locally, on NixOS, unrelated to this change.
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

The Docker, Kubernetes, Podman and VM drivers copied the gateway's
OPENSHELL_TELEMETRY_ENABLED value into every sandbox environment, but
the sandbox supervisor never read it. Drop the injection, the
sandbox_env constant, the core helper that computed the value, and the
tests that pinned the propagation.

Signed-off-by: Simon Scatton <sscatton@nvidia.com>
@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 20, 2026
@krishicks

Copy link
Copy Markdown
Contributor

Drafted by 🤖, signed off by @krishicks

The code change is complete. These docs and comments still describe the propagation and become wrong once this merges:

  1. docs/observability/telemetry.mdx:22: "OpenShell propagates this setting into sandbox supervisor environments, so sandbox-side telemetry collection is disabled as well." Nothing in the sandbox reads it, so this sentence can go.
  2. docs/observability/telemetry.mdx:34: "...and reports telemetry disabled to the sandboxes it launches." Drop the second half.
  3. crates/openshell-driver-vm/Cargo.toml:104-106: the telemetry feature doc says a build without it "reports telemetry disabled to the sandboxes it launches". That was enabled_env_value().
  4. deploy/helm/openshell/values.yaml:466-467: "Enable anonymous OpenShell telemetry from the gateway and the sandbox supervisors it launches." This also needs a regenerated deploy/helm/openshell/README.md:796, and the same wording in docs/kubernetes/setup.mdx:313.
  5. skills/debug-openshell-cluster/SKILL.md:565-566: "the gateway propagates the effective value to sandbox supervisors."

Related, possibly for a later PR in the stack:

  • With the enabled_env_value() calls gone, openshell-driver-vm no longer uses openshell_core::telemetry. Its telemetry feature now does nothing, but telemetry.mdx:30 still lists the VM driver among the binaries to build telemetry-free. The supervisor's telemetry feature was already in the same state.
  • openshell-driver-docker/Cargo.toml:55 also has an unused temp-env dev-dependency. It was unused before this PR, but the reason for dropping it from the Kubernetes and Podman drivers applies here too.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:accepted A maintainer decided OpenShell should pursue this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants