Repository navigation
Conversation
The Docker, Kubernetes, Podman and VM drivers copied the gateway's OPENSHELL_TELEMETRY_ENABLED value into every sandbox environment, but the sandbox supervisor never read it. Drop the injection, the sandbox_env constant, the core helper that computed the value, and the tests that pinned the propagation. Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Contributor
The code change is complete. These docs and comments still describe the propagation and become wrong once this merges:
Related, possibly for a later PR in the stack:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Docker, Kubernetes, Podman and VM drivers copied the gateway's
OPENSHELL_TELEMETRY_ENABLEDvalue into every sandbox environment, but nothing in the sandbox read it. This drops the injection. It is the first of a short stack that removes the NVIDIA usage telemetry ahead of the move to ai-openshell/openshell.Related Issue
Refs #4554
Changes
sandbox_env::TELEMETRY_ENABLEDandopenshell_core::telemetry::enabled_env_value().ENV_LOCKstatics that only served them, and thetemp-envdev-dependency in the Kubernetes and Podman drivers.Release Notes
Testing
cargo clippy -D warnings,cargo fmt, andcargo testfor core and the Docker, Kubernetes, Podman and VM drivers. Only the VMimage_preparationtests that hardcode/bin/sleep//bin/ddfail locally, on NixOS, unrelated to this change.Checklist