From da81b44d071e4500272e3f9828bd9cbc1ce4884d Mon Sep 17 00:00:00 2001 From: jimi-21 Date: Mon, 16 Nov 2026 23:41:48 +0800 Subject: [PATCH 1/2] 4.x: Isolate Observable amb race tests --- .../observable/ObservableAmbIsolatedTest.java | 94 +++++++++++++++++++ 1 file changed, 94 insertions(+) create mode 100644 src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAmbIsolatedTest.java diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAmbIsolatedTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAmbIsolatedTest.java new file mode 100644 index 0000000000..4efa8e4074 --- /dev/null +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAmbIsolatedTest.java @@ -0,0 +1,94 @@ +/* + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is + * distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See + * the License for the specific language governing permissions and limitations under the License. + */ + +package io.reactivex.rxjava4.internal.operators.observable; + +import java.util.List; + +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.parallel.Isolated; + +import io.reactivex.rxjava4.core.*; +import io.reactivex.rxjava4.exceptions.TestException; +import io.reactivex.rxjava4.observers.TestObserver; +import io.reactivex.rxjava4.plugins.RxJavaPlugins; +import io.reactivex.rxjava4.subjects.PublishSubject; +import io.reactivex.rxjava4.testsupport.*; + +@Isolated +public class ObservableAmbIsolatedTest extends RxJavaTest { + + @Test + public void onNextRace() { + for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { + final PublishSubject ps1 = PublishSubject.create(); + final PublishSubject ps2 = PublishSubject.create(); + + TestObserverEx to = Observable.ambArray(ps1, ps2).to(TestHelper.testConsumer()); + + Runnable r1 = () -> ps1.onNext(1); + Runnable r2 = () -> ps2.onNext(1); + + TestHelper.race(r1, r2); + + to.assertSubscribed() + .assertNoErrors() + .assertNotComplete() + .assertValueCount(1); + } + } + + @Test + public void onCompleteRace() { + for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { + final PublishSubject ps1 = PublishSubject.create(); + final PublishSubject ps2 = PublishSubject.create(); + + TestObserver to = Observable.ambArray(ps1, ps2).test(); + + Runnable r1 = ps1::onComplete; + Runnable r2 = ps2::onComplete; + + TestHelper.race(r1, r2); + + to.assertResult(); + } + } + + @Test + public void onErrorRace() { + for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { + final PublishSubject ps1 = PublishSubject.create(); + final PublishSubject ps2 = PublishSubject.create(); + + TestObserver to = Observable.ambArray(ps1, ps2).test(); + + final Throwable ex = new TestException(); + + Runnable r1 = () -> ps1.onError(ex); + Runnable r2 = () -> ps2.onError(ex); + + List errors = TestHelper.trackPluginErrors(); + try { + TestHelper.race(r1, r2); + } finally { + RxJavaPlugins.reset(); + } + + to.assertFailure(TestException.class); + if (!errors.isEmpty()) { + TestHelper.assertUndeliverable(errors, 0, TestException.class); + } + } + } +} From 934a246b8f774d066a1a3ea112885b3d05361f91 Mon Sep 17 00:00:00 2001 From: jimi-21 Date: Mon, 16 Nov 2026 23:41:51 +0800 Subject: [PATCH 2/2] 4.x: Isolate Observable amb race tests --- .../observable/ObservableAmbTest.java | 64 ------------------- 1 file changed, 64 deletions(-) diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAmbTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAmbTest.java index 4ebf2b52a7..9644fbe430 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAmbTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/observable/ObservableAmbTest.java @@ -244,70 +244,6 @@ public void disposed() { TestHelper.checkDisposed(Observable.ambArray(Observable.never(), Observable.never())); } - @Test - public void onNextRace() { - for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishSubject ps1 = PublishSubject.create(); - final PublishSubject ps2 = PublishSubject.create(); - - TestObserverEx to = Observable.ambArray(ps1, ps2).to(TestHelper.testConsumer()); - - Runnable r1 = () -> ps1.onNext(1); - Runnable r2 = () -> ps2.onNext(1); - - TestHelper.race(r1, r2); - - to.assertSubscribed() - .assertNoErrors() - .assertNotComplete() - .assertValueCount(1); - } - } - - @Test - public void onCompleteRace() { - for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishSubject ps1 = PublishSubject.create(); - final PublishSubject ps2 = PublishSubject.create(); - - TestObserver to = Observable.ambArray(ps1, ps2).test(); - - Runnable r1 = ps1::onComplete; - Runnable r2 = ps2::onComplete; - - TestHelper.race(r1, r2); - - to.assertResult(); - } - } - - @Test - public void onErrorRace() { - for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - final PublishSubject ps1 = PublishSubject.create(); - final PublishSubject ps2 = PublishSubject.create(); - - TestObserver to = Observable.ambArray(ps1, ps2).test(); - - final Throwable ex = new TestException(); - - Runnable r1 = () -> ps1.onError(ex); - Runnable r2 = () -> ps2.onError(ex); - - List errors = TestHelper.trackPluginErrors(); - try { - TestHelper.race(r1, r2); - } finally { - RxJavaPlugins.reset(); - } - - to.assertFailure(TestException.class); - if (!errors.isEmpty()) { - TestHelper.assertUndeliverable(errors, 0, TestException.class); - } - } - } - @Test public void ambWithOrder() { Observable error = Observable.error(new RuntimeException());