From 94fc8efe19beb85c9f30a864552ef65d52caeee8 Mon Sep 17 00:00:00 2001 From: jimi-21 Date: Mon, 16 Nov 2026 22:04:45 +0800 Subject: [PATCH 1/4] 4.x: Isolate Completable amb and cache race tests --- .../CompletableAmbIsolatedTest.java | 88 +++++++++++++++++++ 1 file changed, 88 insertions(+) create mode 100644 src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableAmbIsolatedTest.java diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableAmbIsolatedTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableAmbIsolatedTest.java new file mode 100644 index 0000000000..15ae474fcd --- /dev/null +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableAmbIsolatedTest.java @@ -0,0 +1,88 @@ +/* + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is + * distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See + * the License for the specific language governing permissions and limitations under the License. + */ + +package io.reactivex.rxjava4.internal.operators.completable; + +import java.util.*; + +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.parallel.Isolated; + +import io.reactivex.rxjava4.core.*; +import io.reactivex.rxjava4.exceptions.TestException; +import io.reactivex.rxjava4.observers.TestObserver; +import io.reactivex.rxjava4.plugins.RxJavaPlugins; +import io.reactivex.rxjava4.processors.PublishProcessor; +import io.reactivex.rxjava4.subjects.*; +import io.reactivex.rxjava4.testsupport.TestHelper; + +@Isolated +public class CompletableAmbIsolatedTest extends RxJavaTest { + + @Test + public void innerErrorRace() { + for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { + List errors = TestHelper.trackPluginErrors(); + try { + final PublishProcessor pp0 = PublishProcessor.create(); + final PublishProcessor pp1 = PublishProcessor.create(); + + final TestObserver to = Completable.amb(Arrays.asList(pp0.ignoreElements(), pp1.ignoreElements())) + .test(); + + final TestException ex = new TestException(); + + Runnable r1 = () -> pp0.onError(ex); + + Runnable r2 = () -> pp1.onError(ex); + + TestHelper.race(r1, r2); + + to.assertFailure(TestException.class); + + if (!errors.isEmpty()) { + TestHelper.assertUndeliverable(errors, 0, TestException.class); + } + } finally { + RxJavaPlugins.reset(); + } + } + } + + @Test + public void nullSourceSuccessRace() { + for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { + List errors = TestHelper.trackPluginErrors(); + + try { + + final Subject ps = ReplaySubject.create(); + ps.onNext(1); + + final Completable source = Completable.ambArray(ps.ignoreElements(), Completable.never(), Completable.never(), null); + + Runnable r1 = source::test; + + Runnable r2 = ps::onComplete; + + TestHelper.race(r1, r2); + + if (!errors.isEmpty()) { + TestHelper.assertError(errors, 0, NullPointerException.class); + } + } finally { + RxJavaPlugins.reset(); + } + } + } +} From 2779a30302281deef209da9a5bc4f6da05da90de Mon Sep 17 00:00:00 2001 From: jimi-21 Date: Mon, 16 Nov 2026 22:04:48 +0800 Subject: [PATCH 2/4] 4.x: Isolate Completable amb and cache race tests --- .../CompletableCacheIsolatedTest.java | 72 +++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableCacheIsolatedTest.java diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableCacheIsolatedTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableCacheIsolatedTest.java new file mode 100644 index 0000000000..a4397d6d86 --- /dev/null +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableCacheIsolatedTest.java @@ -0,0 +1,72 @@ +/* + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is + * distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See + * the License for the specific language governing permissions and limitations under the License. + */ + +package io.reactivex.rxjava4.internal.operators.completable; + +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.parallel.Isolated; + +import io.reactivex.rxjava4.core.*; +import io.reactivex.rxjava4.observers.TestObserver; +import io.reactivex.rxjava4.subjects.PublishSubject; +import io.reactivex.rxjava4.testsupport.TestHelper; + +@Isolated +public class CompletableCacheIsolatedTest extends RxJavaTest { + + @Test + public void subscribeRace() { + for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { + PublishSubject ps = PublishSubject.create(); + + final Completable c = ps.ignoreElements().cache(); + + final TestObserver to1 = new TestObserver<>(); + + final TestObserver to2 = new TestObserver<>(); + + Runnable r1 = () -> c.subscribe(to1); + Runnable r2 = () -> c.subscribe(to2); + + TestHelper.race(r1, r2); + + ps.onComplete(); + + to1.assertResult(); + to2.assertResult(); + } + } + + @Test + public void subscribeDisposeRace() { + for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { + PublishSubject ps = PublishSubject.create(); + + final Completable c = ps.ignoreElements().cache(); + + final TestObserver to1 = c.test(); + + final TestObserver to2 = new TestObserver<>(); + + Runnable r1 = to1::dispose; + Runnable r2 = () -> c.subscribe(to2); + + TestHelper.race(r1, r2); + + ps.onComplete(); + + to1.assertEmpty(); + to2.assertResult(); + } + } +} From 8bdb4daedceccfd97435332fe12ca8cd5d357d94 Mon Sep 17 00:00:00 2001 From: jimi-21 Date: Mon, 16 Nov 2026 22:04:51 +0800 Subject: [PATCH 3/4] 4.x: Isolate Completable amb and cache race tests --- .../completable/CompletableAmbTest.java | 57 ------------------- 1 file changed, 57 deletions(-) diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableAmbTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableAmbTest.java index 24d30987cc..757b82706a 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableAmbTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableAmbTest.java @@ -74,63 +74,6 @@ public void dispose() { assertFalse(pp2.hasSubscribers()); } - @Test - public void innerErrorRace() { - for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - List errors = TestHelper.trackPluginErrors(); - try { - final PublishProcessor pp0 = PublishProcessor.create(); - final PublishProcessor pp1 = PublishProcessor.create(); - - final TestObserver to = Completable.amb(Arrays.asList(pp0.ignoreElements(), pp1.ignoreElements())) - .test(); - - final TestException ex = new TestException(); - - Runnable r1 = () -> pp0.onError(ex); - - Runnable r2 = () -> pp1.onError(ex); - - TestHelper.race(r1, r2); - - to.assertFailure(TestException.class); - - if (!errors.isEmpty()) { - TestHelper.assertUndeliverable(errors, 0, TestException.class); - } - } finally { - RxJavaPlugins.reset(); - } - } - } - - @Test - public void nullSourceSuccessRace() { - for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - List errors = TestHelper.trackPluginErrors(); - - try { - - final Subject ps = ReplaySubject.create(); - ps.onNext(1); - - final Completable source = Completable.ambArray(ps.ignoreElements(), Completable.never(), Completable.never(), null); - - Runnable r1 = source::test; - - Runnable r2 = ps::onComplete; - - TestHelper.race(r1, r2); - - if (!errors.isEmpty()) { - TestHelper.assertError(errors, 0, NullPointerException.class); - } - } finally { - RxJavaPlugins.reset(); - } - } - } - @Test public void ambWithOrder() { Completable error = Completable.error(new RuntimeException()); From b5fc10d7a25ea979f17a62fe8bc30cc153a621d3 Mon Sep 17 00:00:00 2001 From: jimi-21 Date: Mon, 16 Nov 2026 22:04:54 +0800 Subject: [PATCH 4/4] 4.x: Isolate Completable amb and cache race tests --- .../completable/CompletableCacheTest.java | 47 ------------------- 1 file changed, 47 deletions(-) diff --git a/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableCacheTest.java b/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableCacheTest.java index 85a48d7c0d..dee5814aec 100644 --- a/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableCacheTest.java +++ b/src/test/java/io/reactivex/rxjava4/internal/operators/completable/CompletableCacheTest.java @@ -24,7 +24,6 @@ import io.reactivex.rxjava4.internal.disposables.EmptyDisposable; import io.reactivex.rxjava4.observers.TestObserver; import io.reactivex.rxjava4.subjects.PublishSubject; -import io.reactivex.rxjava4.testsupport.TestHelper; public class CompletableCacheTest extends RxJavaTest implements Consumer, Action { @@ -167,52 +166,6 @@ public void dispose() { to4.assertEmpty(); } - @Test - public void subscribeRace() { - for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - PublishSubject ps = PublishSubject.create(); - - final Completable c = ps.ignoreElements().cache(); - - final TestObserver to1 = new TestObserver<>(); - - final TestObserver to2 = new TestObserver<>(); - - Runnable r1 = () -> c.subscribe(to1); - Runnable r2 = () -> c.subscribe(to2); - - TestHelper.race(r1, r2); - - ps.onComplete(); - - to1.assertResult(); - to2.assertResult(); - } - } - - @Test - public void subscribeDisposeRace() { - for (int i = 0; i < TestHelper.RACE_DEFAULT_LOOPS; i++) { - PublishSubject ps = PublishSubject.create(); - - final Completable c = ps.ignoreElements().cache(); - - final TestObserver to1 = c.test(); - - final TestObserver to2 = new TestObserver<>(); - - Runnable r1 = to1::dispose; - Runnable r2 = () -> c.subscribe(to2); - - TestHelper.race(r1, r2); - - ps.onComplete(); - - to1.assertEmpty(); - to2.assertResult(); - } - } - @Test public void doubleDispose() { PublishSubject ps = PublishSubject.create();